From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, rjwalsh@durables.org
Subject: Re: [PATCH 1/3] netpoll api
Date: Wed, 10 Sep 2003 03:18:45 -0500 [thread overview]
Message-ID: <20030910081845.GF4489@waste.org> (raw)
In-Reply-To: <20030910004907.67b90bd1.akpm@osdl.org>
On Wed, Sep 10, 2003 at 12:49:07AM -0700, Andrew Morton wrote:
> Matt Mackall <mpm@selenic.com> wrote:
> >
> > + spin_lock_irq(&irq_desc[ndev->irq].lock);
> > + for(a=irq_desc[ndev->irq].action; a; a=a->next) {
>
> Lots of architectures do not use irq_desc[]. You'll need abstracted
> per-arch primitives for functions such as this.
Hmmm, linux/irq.h seemed pretty generic. Maybe those other, silly
arches can mend their ways?
Ok, looks like m68k, s390, and sparcx are the only ones not using
irq_desc, and only s390 seems to be far from the irq_desc model. Or I
could be quite mistaken.
I'll be damned if I know what's going on with s390, so I'm not sure
how to get from here to there in terms of coming up with an API for
poking around in ISR lists. Unless you're suggesting I simply make
try_to_find_handler_dev(dev, irq) which seems a little ungainly.
--
Matt Mackall : http://www.selenic.com : of or relating to the moon
next prev parent reply other threads:[~2003-09-10 8:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-10 7:40 [PATCH 1/3] netpoll api Matt Mackall
2003-09-10 7:49 ` Andrew Morton
2003-09-10 8:18 ` Matt Mackall [this message]
2003-09-10 8:39 ` Anton Blanchard
2003-09-10 8:50 ` Russell King
2003-09-10 9:08 ` Matt Mackall
2003-09-10 19:16 ` Benjamin Herrenschmidt
[not found] ` <20030910094259.1e176300.akpm@osdl.org>
2003-09-12 19:59 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030910081845.GF4489@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjwalsh@durables.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox