From: Gerd Knorr <kraxel@bytesex.org>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video/hexium_orion warning removal
Date: Wed, 10 Sep 2003 10:29:44 +0200 [thread overview]
Message-ID: <20030910082944.GB15486@bytesex.org> (raw)
In-Reply-To: <20030909160245.49e8bddd.shemminger@osdl.org>
> diff -Nru a/drivers/media/video/hexium_orion.h b/drivers/media/video/hexium_orion.h
> --- a/drivers/media/video/hexium_orion.h Tue Sep 9 15:56:54 2003
> +++ b/drivers/media/video/hexium_orion.h Tue Sep 9 15:56:54 2003
> @@ -30,109 +30,4 @@
> /*30*/ 0x44,0x75,0x01,0x8C,0x03
> };
>
> -static struct {
> - struct hexium_data data[8];
> -} hexium_input_select[] = {
> -{
> - { /* input 1 */
I'd suggest to #if 0 that instead of deleting, it is probably there for
a reason, maybe just a not completed-yet part of the driver ...
Gerd
next prev parent reply other threads:[~2003-09-10 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-09 23:02 [PATCH] video/hexium_orion warning removal Stephen Hemminger
2003-09-10 8:29 ` Gerd Knorr [this message]
2003-09-11 9:36 ` Michael Hunold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030910082944.GB15486@bytesex.org \
--to=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox