Re: [PATCH] Re: today's futex changes

Andrew Morton
2003-09-08T20:17:29Z

Jamie Lokier <jamie@shareable.org> wrote:
>
> Andrew Morton wrote:
> > Rusty Russell <rusty@rustcorp.com.au> wrote:
> > > D: 4) Andrew Morton says spurious wakeup is a bug. Catch it.
> >
> > Yes, but going BUG() is a bit rude. We can detect the error, we can
> > recover from it and it doesn't cause any user data corruption or anything.
> > A rude printk is all that is needed here.
>
> Well, it should really _never_ happen. We are very careful. Is
> there something like BUG() which doesn't terminate the process?
>

A WARN_ON(1) is good enough. It will spit a stack dump and we will get to
hear about it. Going BUG merely reduces the chances of the info hitting
the logs and irritates our testers.