From: Rusty Russell <rusty@rustcorp.com.au>
To: Felipe W Damasio <felipewd@terra.com.br>
Cc: Jamie Lokier <jamie@shareable.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/futex.c: Uneeded memory barrier
Date: Sun, 14 Sep 2003 21:39:01 +1000 [thread overview]
Message-ID: <20030914114054.CC7CE2C0A7@lists.samba.org> (raw)
In-Reply-To: Your message of "Fri, 12 Sep 2003 15:20:17 -0300." <3F620E61.4080604@terra.com.br>
In message <3F620E61.4080604@terra.com.br> you write:
> Kills an unneeded set_current_state after schedule_timeout, since it
> already guarantees that the task will be TASK_RUNNING.
I thought we already got rid of that once: damn thing won't die...
> Also, when setting the state to TASK_RUNNING, isn't that memory
> barrier unneeded? Patch removes this memory barrier too.
I personally *HATE* the set_task_state()/__set_task_state() macros.
Simple assignments shouldn't be hidden behind macros, unless there's
something really subtle involved.
Personally, when there's a normal and a __ version of a function, I
use the normal version unless there's a real (performance or
correctness) reason. (ie. I prefer the "think less" version 8).
I don't mind either way. I'll roll it in the next update.
Cheers,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2003-09-14 11:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-12 18:20 [PATCH] kernel/futex.c: Uneeded memory barrier Felipe W Damasio
2003-09-12 18:33 ` Felipe W Damasio
2003-09-15 9:39 ` Rusty Russell
2003-09-16 12:05 ` Jamie Lokier
2003-09-13 19:02 ` Jamie Lokier
2003-09-15 1:36 ` Rusty Russell
2003-09-14 11:39 ` Rusty Russell [this message]
2003-09-14 14:08 ` Jamie Lokier
2003-09-15 3:41 ` Rusty Russell
2003-09-15 9:23 ` Russell King
2003-09-15 16:32 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030914114054.CC7CE2C0A7@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=felipewd@terra.com.br \
--cc=jamie@shareable.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox