* qla1280 & __flush_cache_all
[not found] <20030911075609.053a54ed.davem@redhat.com>
@ 2003-09-14 11:11 ` Meelis Roos
2003-09-14 20:46 ` Ralf Baechle
2003-09-15 14:16 ` Jes Sorensen
0 siblings, 2 replies; 4+ messages in thread
From: Meelis Roos @ 2003-09-14 11:11 UTC (permalink / raw)
To: linux-kernel
On Thu, 11 Sep 2003, David S. Miller wrote:
> Meelis Roos <mroos@linux.ee> wrote:
> >
> > Is __flush_cache_all an universal thing or just platform-specific?
> > qla1280 seems to have started using it and it does not link on sparc64.
> >
> > *** Warning: "__flush_cache_all" [drivers/scsi/qla1280.ko] undefined!
>
> There is no reason a scsi driver should be invoking that interface.
So why is qla1280 in 2.6-current using __flush_cache_all?
--
Meelis Roos (mroos@linux.ee)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: qla1280 & __flush_cache_all
2003-09-14 11:11 ` qla1280 & __flush_cache_all Meelis Roos
@ 2003-09-14 20:46 ` Ralf Baechle
2003-09-15 14:16 ` Jes Sorensen
1 sibling, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2003-09-14 20:46 UTC (permalink / raw)
To: Meelis Roos; +Cc: linux-kernel
On Sun, Sep 14, 2003 at 02:11:45PM +0300, Meelis Roos wrote:
> > > Is __flush_cache_all an universal thing or just platform-specific?
> > > qla1280 seems to have started using it and it does not link on sparc64.
> > >
> > > *** Warning: "__flush_cache_all" [drivers/scsi/qla1280.ko] undefined!
> >
> > There is no reason a scsi driver should be invoking that interface.
>
> So why is qla1280 in 2.6-current using __flush_cache_all?
Huh?
[ralf@dea linux-ci]$ grep -r __flush_cache_all drivers/scsi
[ralf@dea linux-ci]$ head Makefile
VERSION = 2
PATCHLEVEL = 6
SUBLEVEL = 0
EXTRAVERSION = -test5
You probably get this reference to __flush_cache_all() via the Sparc64
<asm/cacheflush.h>. Still the cacheflushing in the driver is broken;
the routines in <asm/cacheflush.h> are meant only to maintain cache
coherency wrt. memory managment.
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: qla1280 & __flush_cache_all
2003-09-14 11:11 ` qla1280 & __flush_cache_all Meelis Roos
2003-09-14 20:46 ` Ralf Baechle
@ 2003-09-15 14:16 ` Jes Sorensen
2003-10-04 13:29 ` Meelis Roos
1 sibling, 1 reply; 4+ messages in thread
From: Jes Sorensen @ 2003-09-15 14:16 UTC (permalink / raw)
To: Meelis Roos; +Cc: linux-kernel
>>>>> "Meelis" == Meelis Roos <mroos@linux.ee> writes:
Meelis> So why is qla1280 in 2.6-current using __flush_cache_all?
The driver is calling flush_cache_all() not __flush_cache_all(), the
__ thing is an architecture specific issue.
Yes it's a lazy approach left over from the old codebase.
Cheers,
Jes
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: qla1280 & __flush_cache_all
2003-09-15 14:16 ` Jes Sorensen
@ 2003-10-04 13:29 ` Meelis Roos
0 siblings, 0 replies; 4+ messages in thread
From: Meelis Roos @ 2003-10-04 13:29 UTC (permalink / raw)
To: Jes Sorensen; +Cc: linux-kernel
> Meelis> So why is qla1280 in 2.6-current using __flush_cache_all?
>
> The driver is calling flush_cache_all() not __flush_cache_all(), the
> __ thing is an architecture specific issue.
>
> Yes it's a lazy approach left over from the old codebase.
Yes, it's flush_cache_all() that's causing problems. Current sparc64
doesn't even have flush_cache_all anymore.
--
Meelis Roos (mroos@linux.ee)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-10-04 13:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20030911075609.053a54ed.davem@redhat.com>
2003-09-14 11:11 ` qla1280 & __flush_cache_all Meelis Roos
2003-09-14 20:46 ` Ralf Baechle
2003-09-15 14:16 ` Jes Sorensen
2003-10-04 13:29 ` Meelis Roos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox