From: Rusty Russell <rusty@rustcorp.com.au>
To: Jamie Lokier <jamie@shareable.org>
Cc: Felipe W Damasio <felipewd@terra.com.br>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/futex.c: Uneeded memory barrier
Date: Mon, 15 Sep 2003 11:36:36 +1000 [thread overview]
Message-ID: <20030915054300.74AF72C061@lists.samba.org> (raw)
In-Reply-To: Your message of "Sat, 13 Sep 2003 20:02:42 +0100." <20030913190242.GC7404@mail.jlokier.co.uk>
In message <20030913190242.GC7404@mail.jlokier.co.uk> you write:
> If _all_ instances in the kernel of
>
> set_current_state(TASK_RUNNING)
>
> can be validly turned into
>
> __set_current_state(TASK_RUNNING)
>
> it would be good to make the barrier in set_current_state() itself
> conditional on the state being state.
Or eliminate the macro altogether, and create set_current_interruptible()
and set_current_uninterruptible() which have the barrier, and let the normal
users do the assignment the way God intended 8)
In practice, those who care are using __, the rest aren't critical.
Cheers,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2003-09-15 5:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-12 18:20 [PATCH] kernel/futex.c: Uneeded memory barrier Felipe W Damasio
2003-09-12 18:33 ` Felipe W Damasio
2003-09-15 9:39 ` Rusty Russell
2003-09-16 12:05 ` Jamie Lokier
2003-09-13 19:02 ` Jamie Lokier
2003-09-15 1:36 ` Rusty Russell [this message]
2003-09-14 11:39 ` Rusty Russell
2003-09-14 14:08 ` Jamie Lokier
2003-09-15 3:41 ` Rusty Russell
2003-09-15 9:23 ` Russell King
2003-09-15 16:32 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030915054300.74AF72C061@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=felipewd@terra.com.br \
--cc=jamie@shareable.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox