From: Greg KH <greg@kroah.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org, viro@parcelfarce.linux.theplanet.co.uk
Subject: Re: [PATCH] RFC: Attributes in /sys/cdev
Date: Fri, 19 Sep 2003 16:32:18 -0700 [thread overview]
Message-ID: <20030919233218.GF7808@kroah.com> (raw)
In-Reply-To: <20030919231046.4626.qmail@lwn.net>
On Fri, Sep 19, 2003 at 05:10:46PM -0600, Jonathan Corbet wrote:
> +static ssize_t cdev_dev_read(struct cdev *cd, char *page)
> +{
> + return sprintf(page, "%d:%d\n", MAJOR(cd->firstdev),
> + MINOR(cd->firstdev));
> +}
You should use the print_dev_t() call here instead of doing it by hand.
thanks,
greg k-h
next prev parent reply other threads:[~2003-09-19 23:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-19 23:10 [PATCH] RFC: Attributes in /sys/cdev Jonathan Corbet
2003-09-19 23:32 ` Greg KH [this message]
2003-09-20 1:28 ` viro
2003-09-20 2:47 ` Greg KH
2003-09-22 16:29 ` Patrick Mochel
2003-09-22 16:46 ` Jonathan Corbet
2003-09-22 21:00 ` viro
2003-09-22 21:15 ` Jonathan Corbet
2003-09-22 22:37 ` viro
2003-09-24 22:22 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030919233218.GF7808@kroah.com \
--to=greg@kroah.com \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox