From: Sam Ravnborg <sam@ravnborg.org>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: ink@jurassic.park.msu.ru, maz@wild-wind.fr.eu.org, mec@shout.net,
linux-kernel@vger.kernel.org
Subject: Re: linux-2.6.0-test5/drivers/eisa verbose build failure
Date: Sat, 20 Sep 2003 13:29:12 +0200 [thread overview]
Message-ID: <20030920112912.GA996@mars.ravnborg.org> (raw)
In-Reply-To: <200309152231.h8FMVph11922@freya.yggdrasil.com>
On Mon, Sep 15, 2003 at 03:31:51PM -0700, Adam J. Richter wrote:
> linux-2.6.0-test5/drivers/eisa fails to build if KBUILD_VERBOSE=1
> in the top level Linux Makefile (KBUILD_VERBOSE=1 causes the build
> process to show the actual commands that are being executed).
>
> linux-2.6.0-test5/drivers/eisa/Makefile contains a change
> that tries to use the Linux KBUILD_VERBOSE system to control
> echoing of a command that contains some single quotes. It looks
> like scripts/Makefile.lib contains some macros designed to put
> backslashes in front of single quotes as necessary to handle this
> case, but, somehow, this is not happening.
Good analysis, thanks.
The following patch fixes it for me.
Would you mind trying this and report back.
Sam
===== scripts/Makefile.lib 1.20 vs edited =====
--- 1.20/scripts/Makefile.lib Sun Jun 8 20:06:56 2003
+++ edited/scripts/Makefile.lib Sat Sep 20 09:11:28 2003
@@ -225,7 +225,7 @@
# If quiet is set, only print short version of command
-cmd = @$(if $($(quiet)cmd_$(1)),echo ' $($(quiet)cmd_$(1))' &&) $(cmd_$(1))
+cmd = @$(if $($(quiet)cmd_$(1)),echo ' $(subst ','\'',$($(quiet)cmd_$(1)))' &&) $(cmd_$(1))
# $(call descend,<dir>,<target>)
# Recursively call a sub-make in <dir> with target <target>
next prev parent reply other threads:[~2003-09-20 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-15 22:31 linux-2.6.0-test5/drivers/eisa verbose build failure Adam J. Richter
2003-09-20 11:29 ` Sam Ravnborg [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-09-21 1:51 Adam J. Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030920112912.GA996@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=adam@yggdrasil.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@wild-wind.fr.eu.org \
--cc=mec@shout.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox