From: Dave Jones <davej@redhat.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Kronos <kronos@kronoz.cjb.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix Athlon MCA
Date: Sun, 21 Sep 2003 18:47:31 +0100 [thread overview]
Message-ID: <20030921174731.GA891@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0309211034080.11614-100000@home.osdl.org>
On Sun, Sep 21, 2003 at 10:39:26AM -0700, Linus Torvalds wrote:
> > This messages go away if I revert cset 1.1119.9.1. AFAIK you were trying
> > to decrease the logging level. After reading IA32 Architecture Software
> > Developers Manual, vol3 - chapter 14.5 "Machine-Check Initialization" I
> > think that the right way to do it is this:
>
> Why not just handling the (different) 0-based case in front of the loop:
>
> /* Clear status for MC index 0 separately, we don't touch CTL. */
> wrmsr (MSR_IA32_MC0_STATUS, 0x0, 0x0);
>
> and leave the loop 1-based.
>
> Dave, up to you..
yeah, I prefer that way just for the added comment outside the loop.
expanding it to mention "some athlons don't work with bank 0 enabled"
would be a nice finishing touch.
Dave
--
Dave Jones http://www.codemonkey.org.uk
next prev parent reply other threads:[~2003-09-21 17:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-21 14:39 [PATCH] Fix Athlon MCA Kronos
2003-09-21 14:47 ` Dave Jones
2003-09-21 17:39 ` Linus Torvalds
2003-09-21 17:47 ` Dave Jones [this message]
2003-09-22 14:20 ` CaT
2003-09-22 14:43 ` Dave Jones
2003-09-22 15:06 ` CaT
2003-09-22 16:02 ` Dave Jones
2003-09-22 16:07 ` CaT
2003-09-22 16:20 ` Dave Jones
2003-09-22 13:32 ` venom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030921174731.GA891@redhat.com \
--to=davej@redhat.com \
--cc=kronos@kronoz.cjb.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox