Re: [PATCH] Fix Athlon MCA

Dave Jones
2003-09-21T17:47:55Z

On Sun, Sep 21, 2003 at 10:39:26AM -0700, Linus Torvalds wrote:

> > This messages go away if I revert cset 1.1119.9.1. AFAIK you were trying
> > to decrease the logging level. After reading IA32 Architecture Software
> > Developers Manual, vol3 - chapter 14.5 "Machine-Check Initialization" I
> > think that the right way to do it is this:
>
> Why not just handling the (different) 0-based case in front of the loop:
>
> /* Clear status for MC index 0 separately, we don't touch CTL. */
> wrmsr (MSR_IA32_MC0_STATUS, 0x0, 0x0);
>
> and leave the loop 1-based.
>
> Dave, up to you..

yeah, I prefer that way just for the added comment outside the loop.
expanding it to mention "some athlons don't work with bank 0 enabled"
would be a nice finishing touch.

Dave

--
Dave Jones http://www.codemonkey.org.uk