Re: 2.6.0-test5 vs. Japanese keyboards [3]

OGAWA Hirofumi
2003-09-18T16:15:30Z

Andries Brouwer <aebr@win.tue.nl> writes:

> On Wed, Sep 17, 2003 at 09:35:22PM +0900, OGAWA Hirofumi wrote:
> > Andries Brouwer <aebr@win.tue.nl> writes:
> >
> > > > > OGAWA Hirofumi posted a patch for the yen-sign pipe key on 2003.07.23
> > > > > for test1 but his patch still didn't get into test3.
>
> > > until 2.4 the value of NR_KEYS was 128, while 2.6 uses 256
>
> > in input.h
> > #define KEY_MAX 0x1ff
> > in keyboard.h
> > #define NR_KEYS (KEY_MAX+1)
> >
> > NR_KEYS is 512... Or we should use 256, you mean?
>
> Yes, I think so.
>
> Maybe Vojtech can tell us why he wrote 512, but I just see a
> large amount of wasted space (and, as you already pointed out,
> the need for new ioctls) if one uses 512.
>
> As far as I can see, everything works with 256.
> Indeed, everything seems to assume 256.

That sounds good to me. Vojtech, did we need NR_KEYS(KEY_MAX?) greater
than 256?
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>