From: Oleg Drokin <green@linuxhacker.ru>
To: marcelo@conectiva.com.br, linux-kernel@vger.kernel.org, greg@kroah.com
Subject: [PATCH] [2.4] devio.c memleak on unexpected disconnect
Date: Sun, 21 Sep 2003 22:59:22 +0400 [thread overview]
Message-ID: <20030921185922.GA1185@linuxhacker.ru> (raw)
Hello!
There is a memleak in devio.c (User space communication with USB devices)
recently added, it forgets to free the buffer if device was disconnected.
The patch is trivial, please apply.
Found with help of smatch.
===== drivers/usb/devio.c 1.17 vs edited =====
--- 1.17/drivers/usb/devio.c Mon Aug 19 20:49:38 2002
+++ edited/drivers/usb/devio.c Sun Sep 21 22:51:15 2003
@@ -1114,7 +1114,7 @@
usb_driver_release_interface (driver, ifp);
up (&driver->serialize);
} else
- return -ENODATA;
+ retval = -ENODATA;
break;
/* let kernel drivers try to (re)bind to the interface */
next reply other threads:[~2003-09-21 18:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-21 18:59 Oleg Drokin [this message]
2003-09-24 21:34 ` [PATCH] [2.4] devio.c memleak on unexpected disconnect Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030921185922.GA1185@linuxhacker.ru \
--to=green@linuxhacker.ru \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox