Re: 2.6.0-test5-mm4: BeFS compile error

Will Dyson
2003-09-22T17:57:23Z

On Mon, 2003-09-22 at 07:49, Adrian Bunk wrote:
> On Mon, Sep 22, 2003 at 01:35:48AM -0700, Andrew Morton wrote:
> >...
> > befs-use-parser.patch
> > BEFS: Use table-driven option parsing
> >...
>
> It seems this patch broke the compilation of BeFS:
>
> <-- snip -->
>
> ...
> CC fs/befs/linuxvfs.o
> fs/befs/linuxvfs.c: In function `parse_options':
> fs/befs/linuxvfs.c:712: too few arguments to function `match_int'
> fs/befs/linuxvfs.c:724: too few arguments to function `match_int'
> make[2]: *** [fs/befs/linuxvfs.o] Error 1

Seems Andrew merged a different version of the options patch than the
one that was posted to the list. I can make a fixup tonight.

Also, from looking at the test5-mm4 patch, I think that match_number()
from lib/parser.c is ignoring the base argument and using a hardcoded
value of zero for the simple_strtol() call. This should result in
match_octal() and match_hex() being broken (well, being the same as
match_int).

--
Will Dyson
"Back off man, I'm a scientist!" -Dr. Peter Venkman