Re: 2.6.0-test5-mm4

Peter Osterlund
2003-09-25T00:13:24Z

Vojtech Pavlik <vojtech@suse.cz> writes:

> On Mon, Sep 22, 2003 at 11:27:17PM +0200, Peter Osterlund wrote:
> > Andrew Morton <akpm@osdl.org> writes:
> >
> > > Zilvinas Valinskas <zilvinas@gemtek.lt> wrote:
> > > >
> > > > Btw Andrew ,
> > > >
> > > > this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver
> > > > from http://w1.894.telia.com/~u89404340/touchpad/index.html.
> > > >
> > > >
> > > > -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/
> > > > 2", "ImPS/2", "ImExPS/2", "Synaptics"};
> > > > +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"};
> > >
> > > You mean it breaks the XFree driver? Is it just a matter of editing
> > > XF86Config to tell it the new protocl name?
> >
> > It breaks the event device auto detection, which works by parsing
> > /proc/bus/input/devices. The protocol name is hard coded so you can't
> > just change the XF86Config file.
> >
> > > Either way, it looks like a change which should be reverted?
> >
> > I think the new protocol name is better, so why not just fix the X
> > driver instead. Here is a fixed version:
> >
> > http://w1.894.telia.com/~u89404340/touchpad/synaptics-0.11.4.tar.bz2
>
> I'd suggest the driver either checks the BUS/VENDOR/DEVICE ids or the
> bitfields for the pad, not the name. Names are unreliable ...

OK, this is now implemented in version 0.11.5, which I just uploaded
to my web site. This version also adds support for the new events
ABS_TOOL_WIDTH, BTN_TOOL_FINGER, BTN_TOOL_DOUBLETAP and
BTN_TOOL_TRIPLETAP.

--
Peter Osterlund - petero2@telia.com