From: Paul Mundt <lethal@linux-sh.org>
To: Matt Mackall <mpm@selenic.com>
Cc: Andrew Morton <akpm@osdl.org>,
Robert Walsh <rjwalsh@durables.org>,
wangdi <wangdi@clusterfs.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] netpoll-core
Date: Mon, 22 Sep 2003 21:19:47 -0400 [thread overview]
Message-ID: <20030923011947.GA9873@linux-sh.org> (raw)
In-Reply-To: <20030922184526.GL2414@waste.org>
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
On Mon, Sep 22, 2003 at 01:45:26PM -0500, Matt Mackall wrote:
> +static void zap_completion_queue(void)
> +{
> + unsigned long flags;
> + struct softnet_data *sd = &get_cpu_var(softnet_data);
> +
> + if (sd->completion_queue) {
> + struct sk_buff *clist;
> +
> + local_irq_save(flags);
> + clist = sd->completion_queue;
> + sd->completion_queue = NULL;
> + local_irq_save(flags);
^^^^^^^^^^^^^^^^^^^^^
Two consecutive local_irq_save()'s?
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2003-09-23 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-22 18:45 [PATCH 1/3] netpoll-core Matt Mackall
2003-09-23 0:58 ` Jeff Garzik
2003-09-23 4:16 ` Matt Mackall
2003-09-23 1:19 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030923011947.GA9873@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=rjwalsh@durables.org \
--cc=wangdi@clusterfs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox