From: Kevin Corry <kevcorry@us.ibm.com>
To: viro@parcelfarce.linux.theplanet.co.uk,
Joe Thornber <ethornber@yahoo.co.uk>
Cc: torvalds@osdl.org, akpm@zip.com.au, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] DM 1/6: Use new format_dev_t macro
Date: Tue, 23 Sep 2003 09:07:02 -0500 [thread overview]
Message-ID: <200309230907.02375.kevcorry@us.ibm.com> (raw)
In-Reply-To: <20030923075736.GK7665@parcelfarce.linux.theplanet.co.uk>
On Tuesday 23 September 2003 02:57, viro@parcelfarce.linux.theplanet.co.uk
wrote:
> On Tue, Sep 23, 2003 at 08:57:07AM +0100, Joe Thornber wrote:
> > On Monday, September 22, 2003, at 08:29 PM,
> >
> > viro@parcelfarce.linux.theplanet.co.uk wrote:
> > >On Mon, Sep 22, 2003 at 10:51:27AM -0500, Kevin Corry wrote:
> > >>Use the format_dev_t function for target status functions.
> > >
> > >[instead of bdevname, that is]
> > >
> > >It's wrong. Simply because "sdb3" is immediately parsed by admin and
> > >08:13 is nowhere near that convenient. These are error messages, let's
> > >keep them readable.
> >
> > No they are not just error messages, userland tools use them.
>
> In which case the change in question would break said userland tools,
> wouldn't it?
No, actually this change brings the status info back in-line with how the 2.4
version of DM behaves. A while back the bdevname() function changed to return
a text name (it used to return a major:minor, similar to kdevname in 2.4). In
many cases the only way to make any sense of this text name is to search
around in sysfs for a matching entry (provided, of course, that sysfs is
mounted, which many people still don't realize they should be doing. :) And
if you find that entry in sysfs, the info you're really looking for is in the
"dev" file, whose contents are displayed using format_dev_t().
--
Kevin Corry
kevcorry@us.ibm.com
http://evms.sourceforge.net/
next prev parent reply other threads:[~2003-09-23 14:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-22 15:44 2.6.0-test5-mm2 Device Mapper Patches Kevin Corry
2003-09-22 15:51 ` [PATCH] DM 1/6: Use new format_dev_t macro Kevin Corry
2003-09-22 19:29 ` viro
2003-09-23 7:57 ` Joe Thornber
2003-09-23 7:57 ` viro
2003-09-23 14:07 ` Kevin Corry [this message]
2003-09-22 15:51 ` [PATCH] DM 2/6: Drop extra table ref-count Kevin Corry
2003-09-22 15:52 ` [PATCH] DM 3/6: Move retrieve_status function Kevin Corry
2003-09-22 15:52 ` [PATCH] DM 4/6: Return table status for dev_wait Kevin Corry
2003-09-22 15:52 ` [PATCH] DM 5/6: Message fix in dm-linear Kevin Corry
2003-09-22 15:53 ` [PATCH] DM 6/6: Support arbitrary number of target params Kevin Corry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200309230907.02375.kevcorry@us.ibm.com \
--to=kevcorry@us.ibm.com \
--cc=akpm@zip.com.au \
--cc=ethornber@yahoo.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox