From: Christoph Hellwig <hch@infradead.org>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] i2c driver fixes for 2.6.0-test5
Date: Tue, 23 Sep 2003 09:16:17 +0100 [thread overview]
Message-ID: <20030923091617.B10818@infradead.org> (raw)
In-Reply-To: <1064273428551@kroah.com>; from greg@kroah.com on Mon, Sep 22, 2003 at 04:30:28PM -0700
On Mon, Sep 22, 2003 at 04:30:28PM -0700, Greg KH wrote:
> for (addr = 0x00; addr <= (is_isa ? 0xffff : 0x7f); addr++) {
> - /* XXX: WTF is going on here??? */
> - if ((is_isa && check_region(addr, 1)) ||
> + void *region_used = request_region(addr, 1, "foo");
> + release_region(addr, 1);
> + if ((is_isa && (region_used == NULL)) ||
WTF?? Your papering over bugs again, this doesn't help at all.
next prev parent reply other threads:[~2003-09-23 8:16 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <10642734271572@kroah.com>
2003-09-22 23:30 ` [PATCH] i2c driver fixes for 2.6.0-test5 Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-23 8:16 ` Christoph Hellwig [this message]
2003-09-23 16:19 ` Greg KH
2003-09-23 16:22 ` Christoph Hellwig
2003-09-23 19:04 ` Greg KH
2003-09-23 19:08 ` Christoph Hellwig
2003-09-22 23:28 [BK PATCH] " Greg KH
2003-09-22 23:30 ` [PATCH] " Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
2003-09-22 23:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030923091617.B10818@infradead.org \
--to=hch@infradead.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox