Re: [CHECKER] 32 Memory Leaks on Error Paths

[Greg KH <greg@kroah.com>]

On Tue, Sep 23, 2003 at 01:13:50PM -0700, Chris Wright wrote:
> * David Yu Chen (dychen@stanford.edu) wrote:
> > Leaks if devices == 0 ?  Error_end only frees mdevs if (devices > 0), 
> > but for mdevs=kmalloc(0), the slab allocator may still actually return memory
> > [FILE:  2.6.0-test5/drivers/usb/class/usb-midi.c]
> > [FUNC:  alloc_usb_midi_device]
> > [LINES: 1621-1772]
> > [VAR:   mdevs]
> > 1616:	devices = inDevs > outDevs ? inDevs : outDevs;
> > 1617:	devices = maxdevices > devices ? devices : maxdevices;
> > 1618:
> > 1619:	/* obtain space for device name (iProduct) if not known. */
> > 1620:	if ( ! u->deviceName ) {
> > START -->
> > 1621:		mdevs = (struct usb_mididev **)
> > 1622:			kmalloc(sizeof(struct usb_mididevs *)*devices
> > 1623:				+ sizeof(char) * 256, GFP_KERNEL);
> <snip>
> > GOTO -->
> > 1715:			goto error_end;
> <snip>
> > END -->
> > 1772:	return -ENOMEM;
> > [FILE:  2.6.0-test5/drivers/usb/class/usb-midi.c]
> > START -->
> > 1625:		mdevs = (struct usb_mididev **)
> > 1626:			kmalloc(sizeof(struct usb_mididevs *)*devices, GFP_KERNEL);
> <snip>
> > GOTO -->
> > 1715:			goto error_end;
> <snip>
> > END -->
> > 1772:	return -ENOMEM;
> 
> Yes, these are bugs.  Patch below.  Greg, this look ok?

Don't know, Vojtech said he would fix these up already.  Try asking him
:)

thanks,

greg k-h