Re: [PATCH] autofs4 deadlock during expire - kernel 2.6

Ian Kent
2003-09-24T13:52:29Z

On Wed, 24 Sep 2003, Arjan van de Ven wrote:

> On Wed, 2003-09-24 at 15:01, Ian Kent wrote:
> > This is a corrected patch for the autofs4 daedlock problem I posted about
> > @@ -206,6 +207,11 @@
> >
> > interruptible_sleep_on(&wq->queue);
> >
> > + if (waitqueue_active(&wq->queue) && current != wq->owner) {
> > + set_current_state(TASK_INTERRUPTIBLE);
> > + schedule_timeout(wq->wait_ctr * (HZ/10));
> > + }
> > +
>
> this really really looks like you're trying to pamper over a bug by
> changing the timing somewhere instead of fixing it...

Agreed.

>
> also are you sure the deadlock isn't because of the racey use of
> interruptible_sleep_on ?
>

OK so maybe I should have suggestions instead of comments.

Please elaborate.