From: Muli Ben-Yehuda <mulix@mulix.org>
To: Ram?n Rey Vicente <ramon.rey@hispalinux.es>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [patch][2.6.0-test6] ALSA pci Kconfig polishes
Date: Mon, 29 Sep 2003 09:09:05 +0300 [thread overview]
Message-ID: <20030929060905.GU729@actcom.co.il> (raw)
In-Reply-To: <1064804924.11516.3.camel@debian>
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
On Mon, Sep 29, 2003 at 05:08:45AM +0200, Ram?n Rey Vicente wrote:
> Hi.
>
> I think the ALSA pci devices must select the GAMEPORT option
> automatically instead of depends on GAMEPORT.
>
> The GAMEPORT is a feature of the device, is not a requisite.
This patch makes GAMEPORT required, while actually it's only required
to not be a module if the sound driver is builtin. See my earlier mail
on the subject for the details:
http://marc.theaimsgroup.com/?l=linux-kernel&m=106479206731633&w=2
A better fix would be to revert the change in sound/pci/Kconfig from
CONFIG_SOUND_GAMEPORT to CONFIG_GAMEPORT back to
CONFIG_SOUND_GAMEPORT, or just drop this dependency for ALSA and let
the #ifdefs in the code take care of it. Forcing the gameport to be
compiled in when it's not necessary is bloat, IMHO.
--
Muli Ben-Yehuda
http://www.mulix.org
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2003-09-29 6:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-29 3:08 [patch][2.6.0-test6] ALSA pci Kconfig polishes Ramón Rey Vicente
2003-09-29 6:09 ` Muli Ben-Yehuda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030929060905.GU729@actcom.co.il \
--to=mulix@mulix.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ramon.rey@hispalinux.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox