From: Jeff Garzik <jgarzik@pobox.com>
To: davej@redhat.com
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ULL fixes for qlogicfc
Date: Mon, 29 Sep 2003 13:23:29 -0400 [thread overview]
Message-ID: <20030929172329.GD6526@gtf.org> (raw)
In-Reply-To: <E1A41Rq-0000NJ-00@hardwired>
On Mon, Sep 29, 2003 at 06:04:34PM +0100, davej@redhat.com wrote:
> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/scsi/qlogicfc.c linux-2.5/drivers/scsi/qlogicfc.c
> --- bk-linus/drivers/scsi/qlogicfc.c 2003-09-08 00:47:00.000000000 +0100
> +++ linux-2.5/drivers/scsi/qlogicfc.c 2003-09-08 01:30:56.000000000 +0100
> @@ -718,8 +718,8 @@ int isp2x00_detect(Scsi_Host_Template *
> continue;
>
> /* Try to configure DMA attributes. */
> - if (pci_set_dma_mask(pdev, (u64) 0xffffffffffffffff) &&
> - pci_set_dma_mask(pdev, (u64) 0xffffffff))
> + if (pci_set_dma_mask(pdev, 0xffffffffffffffffULL) &&
> + pci_set_dma_mask(pdev, 0xffffffffULL))
> continue;
Looks great.
I wonder if you are motivated to create similar pci_set_dma_mask()
cleanups for other drivers? ;-) Several other drivers need this same
cleanup, too.
Jeff
next prev parent reply other threads:[~2003-09-29 17:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-29 17:04 [PATCH] ULL fixes for qlogicfc davej
2003-09-29 17:23 ` Jeff Garzik [this message]
2003-09-29 17:26 ` Dave Jones
2003-09-29 20:25 ` H. Peter Anvin
2003-09-29 20:33 ` Arjan van de Ven
2003-09-29 21:11 ` Jeff Garzik
2003-09-29 21:11 ` Jeff Garzik
2003-09-29 21:24 ` H. Peter Anvin
2003-09-29 21:36 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030929172329.GD6526@gtf.org \
--to=jgarzik@pobox.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox