From: viro@parcelfarce.linux.theplanet.co.uk
To: Bernd Eckenfels <ecki@calista.eckenfels.6bone.ka-ip.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] linuxabi
Date: Wed, 1 Oct 2003 04:34:37 +0100 [thread overview]
Message-ID: <20031001033437.GP7665@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <E1A4WNJ-000182-00@calista.inka.de>
On Wed, Oct 01, 2003 at 04:05:57AM +0200, Bernd Eckenfels wrote:
> > +#define MS_NODIRATIME 2048 /* Do not update directory access times */
> > +#define MS_BIND 4096
> > +#define MS_POSIXACL (1<<16) /* VFS does not apply the umask */
>
> can we clean that up? with shifting, without shifting, with comments and without comments? I suggest to use the linuxdoc comments mandatory for the abi files.
... and make it enum, while we are at it. It's cleaner, it survives cpp
and it can be handled by gdb et.al. in sane way.
Unless we really want to support pre-v7 compilers, there is no benefit
in using #define for such constants.
next prev parent reply other threads:[~2003-10-01 3:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-01 0:01 [PATCH] linuxabi Andries.Brouwer
2003-10-01 2:05 ` Bernd Eckenfels
2003-10-01 3:34 ` viro [this message]
2003-10-01 4:52 ` H. Peter Anvin
2003-10-01 5:22 ` Philippe Troin
2003-10-01 5:50 ` Miles Bader
2003-10-01 14:33 ` Daniel Jacobowitz
2003-10-01 10:20 ` J.A. Magallon
2003-10-02 14:39 ` Eric W. Biederman
2003-10-02 15:33 ` Andries Brouwer
2003-10-03 7:36 ` Eric W. Biederman
2003-10-04 3:37 ` Rob Landley
2003-10-04 6:31 ` Erik Andersen
[not found] ` <fa.e2g5r6g.u3igb4@ifi.uio.no>
2003-10-03 16:49 ` Kai Henningsen
2003-10-03 17:32 ` Sam Ravnborg
[not found] <BCSP.62t.7@gated-at.bofh.it>
[not found] ` <CcWl.7kh.9@gated-at.bofh.it>
[not found] ` <CdIL.8ts.13@gated-at.bofh.it>
2003-10-03 14:02 ` Ihar 'Philips' Filipau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031001033437.GP7665@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=ecki@calista.eckenfels.6bone.ka-ip.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox