From: viro@parcelfarce.linux.theplanet.co.uk
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: Al Smith <Al.Smith@aeschi.ch.eu.org>,
linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Subject: Re: include/linux/efs_fs.h declares a symbol
Date: Wed, 1 Oct 2003 14:14:57 +0100 [thread overview]
Message-ID: <20031001131456.GR7665@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20031001121643.GD31698@wohnheim.fh-wedel.de>
> Al Viro: There is no maintainer for efs in the kernel MAINTAINERS
> file. Is this filesystem orphaned?
Beats me. As far as I can see, all updates to it were 3rd-party. It's
either abandoned, or never required specific patches too badly (also
quite possible in this case).
It went into the tree in 2.3.2 and from there to 2.6.0-test6 I see nothing
that would look like maintainer's update. OTOH, it's read-only and shouldn't
be too badly broken (or hard to keep alive).
Outside of trunk (i.e. in 2.4.16--) we have a backport of global 2.5 change
(sb_bread()) and check for set_blocksize() failures (from Alan). BTW, the
latter patch is missing in 2.5. Its equivalent would be
--- B6/fs/efs/super.c Mon Jun 23 07:23:09 2003
+++ B6-efs/fs/efs/super.c Wed Oct 1 08:58:35 2003
@@ -218,7 +218,11 @@
memset(sb, 0, sizeof(struct efs_sb_info));
s->s_magic = EFS_SUPER_MAGIC;
- sb_set_blocksize(s, EFS_BLOCKSIZE);
+ if (!sb_set_blocksize(s, EFS_BLOCKSIZE)) {
+ printk(KERN_ERR "EFS: device does not support %d byte blocks\n",
+ EFS_BLOCKSIZE);
+ goto out_no_fs_ul;
+ }
/* read the vh (volume header) block */
bh = sb_bread(s, 0);
prev parent reply other threads:[~2003-10-01 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-01 12:16 include/linux/efs_fs.h declares a symbol Jörn Engel
2003-10-01 13:14 ` Al Smith
2003-10-01 13:14 ` viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031001131456.GR7665@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=Al.Smith@aeschi.ch.eu.org \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox