From: Muli Ben-Yehuda <mulix@mulix.org>
To: Dave Jones <davej@redhat.com>, Matthew Wilcox <willy@debian.org>,
Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CONFIG_* In Comments Considered Harmful
Date: Wed, 1 Oct 2003 17:41:43 +0300 [thread overview]
Message-ID: <20031001144143.GG29313@actcom.co.il> (raw)
In-Reply-To: <20031001141950.GA13115@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
On Wed, Oct 01, 2003 at 03:19:52PM +0100, Dave Jones wrote:
> Maybe it should be taught to parse comments? There are zillions of
> #endif /* CONFIG_FOO */
> braces in the tree. Why is this one special ?
I wondered the same, until I noticed:
#if defined(WANT_PAGE_VIRTUAL)
^^^^^^^^^^^^^^^^^
void *virtual; /* Kernel virtual address (NULL if
not kmapped, ie. highmem) */
#endif /* CONFIG_HIGMEM || WANT_PAGE_VIRTUAL */
^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^
the #defined check is on WANT_PAGE_VIRTUAL only - the script tripped
over CONFIG_HIGMEM, which is in the #endif only.
--
Muli Ben-Yehuda
http://www.mulix.org
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-10-01 14:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-01 13:26 [PATCH] CONFIG_* In Comments Considered Harmful Matthew Wilcox
2003-10-01 14:19 ` Dave Jones
2003-10-01 14:29 ` Valdis.Kletnieks
2003-10-01 14:42 ` Jörn Engel
2003-10-01 14:49 ` Matthew Wilcox
2003-10-01 14:41 ` Muli Ben-Yehuda [this message]
2003-10-01 14:39 ` Jörn Engel
[not found] ` <20031001145206.GH29313@actcom.co.il>
2003-10-01 15:10 ` Jörn Engel
2003-10-01 20:15 ` Muli Ben-Yehuda
2003-10-01 20:27 ` Linus Torvalds
2003-10-01 14:58 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031001144143.GG29313@actcom.co.il \
--to=mulix@mulix.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox