From: Matt Mackall <mpm@selenic.com>
To: Erlend Aasland <erlend-a@ux.his.no>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steve French <sfrench@samba.org>,
Samba Technical Mailing List <samba-technical@samba.org>,
James Morris <jmorris@intercode.com.au>
Subject: Re: [PATCH CIFS] use CryptoAPI MD4/MD5
Date: Wed, 1 Oct 2003 14:55:22 -0500 [thread overview]
Message-ID: <20031001195522.GK1897@waste.org> (raw)
In-Reply-To: <20031001133039.GA32610@badne3.ux.his.no>
On Wed, Oct 01, 2003 at 03:30:39PM +0200, Erlend Aasland wrote:
> static int cifs_calculate_signature(const struct smb_hdr * cifs_pdu, const char * key, char * signature)
[...]
> + spin_lock(&md5_tfm_lock);
> + crypto_digest_init(md5_tfm);
> + crypto_digest_update(md5_tfm, sg, 2);
> + crypto_digest_final(md5_tfm, signature);
> + spin_unlock(&md5_tfm_lock);
Eek. How often does this get called? We're now up to three instances
of CryptoAPI conversion (/dev/random, cryptoloop, and cifs) that want
tfms-on-the-stack but instead use extra locking.
--
Matt Mackall : http://www.selenic.com : of or relating to the moon
next prev parent reply other threads:[~2003-10-01 19:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-02 20:30 [RFC][PATCH] 2nd try to convert cifs to use CryptoAPI Erlend Aasland
2003-10-01 13:30 ` [PATCH CIFS] use CryptoAPI MD4/MD5 Erlend Aasland
2003-10-01 19:55 ` Matt Mackall [this message]
2003-10-01 23:26 ` Erlend Aasland
2003-10-01 23:42 ` Matt Mackall
2003-10-01 23:52 ` Erlend Aasland
[not found] <OF9C1504BB.5FB00D5A-ON87256DB3.0015672E-86256DB3.001798AE@us.ibm.com>
2003-10-02 11:37 ` Erlend Aasland
2003-10-04 18:00 ` dean gaudet
2003-10-04 18:24 ` Matt Mackall
2003-10-04 18:51 ` dean gaudet
2003-10-04 20:08 ` Francois Romieu
2003-10-05 0:08 ` Matt Mackall
2003-10-05 12:29 ` Erlend Aasland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031001195522.GK1897@waste.org \
--to=mpm@selenic.com \
--cc=erlend-a@ux.his.no \
--cc=jmorris@intercode.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox