public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: kernel list <linux-kernel@vger.kernel.org>,
	Patrick Mochel <mochel@osdl.org>
Subject: [pm] fix oops after saving image
Date: Thu, 2 Oct 2003 00:37:52 +0200	[thread overview]
Message-ID: <20031001223751.GA6402@elf.ucw.cz> (raw)

Hi!

I was seeing strange oopsen after saving image. They are almost
harmless: anything that happens after writing final signature does not
matter (as long as  it does not write to disk). But that oops makes
testing hard as you have to manually powerdown the machine.

free_page() at this point is unneccessary as machine is going down,
anyway. Please apply,
								Pavel
PS: For a test, I'm running while true; do echo 4 > /proc/acpi/sleep;
sleep 30; done while making kernel. It seems to work so far.

--- tmp/linux/kernel/power/swsusp.c	2003-10-02 00:04:35.000000000 +0200
+++ linux/kernel/power/swsusp.c	2003-10-01 23:56:49.000000000 +0200
@@ -345,7 +348,7 @@
 	printk( "|\n" );
 
 	MDELAY(1000);
-	free_page((unsigned long) buffer);
+	/* Trying to free_page((unsigned long) buffer) here is bad idea, not sure why */
 	return 0;
 }
 
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]

             reply	other threads:[~2003-10-01 22:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-01 22:37 Pavel Machek [this message]
2003-10-02 16:40 ` [pm] fix oops after saving image Patrick Mochel
2003-10-02 20:39   ` Pavel Machek
2003-10-03 21:38     ` Patrick Mochel
2003-10-03 22:33       ` Pavel Machek
2003-10-04  5:17         ` Stan Bubrouski
2003-10-04  8:02           ` Pavel Machek
2003-10-04  7:50             ` Nigel Cunningham
2003-10-04 16:27               ` Stan Bubrouski
2003-10-04 16:26             ` Stan Bubrouski
2003-10-04 16:39               ` Pavel Machek
2003-10-04 16:53                 ` Stan Bubrouski
2003-10-06 22:30         ` Patrick Mochel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031001223751.GA6402@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox