From: Sam Ravnborg <sam@ravnborg.org>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: Russell King <rmk@arm.linux.org.uk>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] remove unnecessary #includes from <linux/fs.h>
Date: Thu, 2 Oct 2003 19:22:19 +0200 [thread overview]
Message-ID: <20031002172219.GA925@mars.ravnborg.org> (raw)
In-Reply-To: <20031002161639.GF10382@wohnheim.fh-wedel.de>
On Thu, Oct 02, 2003 at 06:16:39PM +0200, Jörn Engel wrote:
>
> You didn't comment on my suggestion, so I've done it manually once for
> linux/fs.h and was shocked. It still passes my compile-standalone
> test after removing 11! #include lines.
Be careful here.
Maybe fs.h passes your compile test, but it may break other users of
fs.h, that relyed on a certain .h file to be included by fs.h.
This kind of clean-up belongs to 2.7.
Sam
next prev parent reply other threads:[~2003-10-02 17:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-28 10:14 Linux 2.6.0-test6 Geert Uytterhoeven
2003-09-28 12:50 ` Russell King
2003-09-28 13:54 ` Bernardo Innocenti
2003-09-28 17:37 ` Linus Torvalds
2003-09-28 18:46 ` Sam Ravnborg
2003-09-28 18:52 ` Linus Torvalds
2003-09-28 19:44 ` Jamie Lokier
2003-09-28 19:16 ` Jörn Engel
2003-09-28 19:31 ` Sam Ravnborg
2003-09-28 19:44 ` Jörn Engel
2003-09-29 13:36 ` [PATCH] check headers for complete includes, etc Jörn Engel
2003-09-29 13:40 ` Jörn Engel
2003-09-29 14:50 ` Sam Ravnborg
2003-09-29 15:00 ` Jörn Engel
2003-09-29 17:10 ` Dominik Kubla
2003-10-01 9:48 ` [PATCH v2] " Jörn Engel
2003-10-01 16:39 ` Sam Ravnborg
2003-10-01 17:00 ` Jörn Engel
2003-10-01 18:01 ` [PATCH v3] " Jörn Engel
2003-10-01 21:09 ` Sam Ravnborg
2003-10-02 8:37 ` [PATCH v4] " Jörn Engel
2003-09-28 19:42 ` Linux 2.6.0-test6 Russell King
2003-09-28 20:00 ` Jörn Engel
2003-09-28 21:43 ` Tim Schmielau
2003-09-28 21:54 ` Arnaldo Carvalho de Melo
2003-10-02 16:16 ` [PATCH] remove unnecessary #includes from <linux/fs.h> Jörn Engel
2003-10-02 17:22 ` Sam Ravnborg [this message]
2003-10-02 17:26 ` Jörn Engel
2003-10-03 15:03 ` Tim Schmielau
2003-09-29 15:08 ` Linux 2.6.0-test6 Chris Friesen
2003-09-29 15:14 ` Geert Uytterhoeven
2003-09-28 19:28 ` Russell King
2003-09-29 8:52 ` Geert Uytterhoeven
2003-09-29 19:19 ` bill davidsen
2003-09-30 10:42 ` Jörn Engel
2003-09-30 15:17 ` Bill Davidsen
2003-10-01 9:08 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031002172219.GA925@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox