From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263400AbTJBRWX (ORCPT ); Thu, 2 Oct 2003 13:22:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263401AbTJBRWX (ORCPT ); Thu, 2 Oct 2003 13:22:23 -0400 Received: from pasmtp.tele.dk ([193.162.159.95]:58117 "EHLO pasmtp.tele.dk") by vger.kernel.org with ESMTP id S263400AbTJBRWW (ORCPT ); Thu, 2 Oct 2003 13:22:22 -0400 Date: Thu, 2 Oct 2003 19:22:19 +0200 From: Sam Ravnborg To: =?iso-8859-1?Q?J=F6rn?= Engel Cc: Russell King , Kernel Mailing List , Sam Ravnborg Subject: Re: [PATCH] remove unnecessary #includes from Message-ID: <20031002172219.GA925@mars.ravnborg.org> Mail-Followup-To: =?iso-8859-1?Q?J=F6rn?= Engel , Russell King , Kernel Mailing List , Sam Ravnborg References: <20030928184642.GA1681@mars.ravnborg.org> <20030928191622.GA16921@wohnheim.fh-wedel.de> <20030928204224.G1428@flint.arm.linux.org.uk> <20030928200001.GC16921@wohnheim.fh-wedel.de> <20031002161639.GF10382@wohnheim.fh-wedel.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20031002161639.GF10382@wohnheim.fh-wedel.de> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 02, 2003 at 06:16:39PM +0200, Jörn Engel wrote: > > You didn't comment on my suggestion, so I've done it manually once for > linux/fs.h and was shocked. It still passes my compile-standalone > test after removing 11! #include lines. Be careful here. Maybe fs.h passes your compile test, but it may break other users of fs.h, that relyed on a certain .h file to be included by fs.h. This kind of clean-up belongs to 2.7. Sam