public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6.0-test6] definition and usage of __u64/__s64 inconsistent?
@ 2003-10-03  8:54 Michal Kochanowicz
  2003-10-03  9:03 ` David S. Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Michal Kochanowicz @ 2003-10-03  8:54 UTC (permalink / raw)
  To: linux-kernel

Hi!

The two types are _conditionally_ defined as follows (in asm/types.h):
#if defined(__GNUC__) && !defined(__STRICT_ANSI__)
typedef __signed__ long long __s64;
typedef unsigned long long __u64;
#endif

The file asm/types.h is _unconditionally_ included from linux/cdrom.h
and linux/loop.h and both files use __u64 unonditionally. Isn't this an
error?

Regards

PS. I came across this problem while trying to compile
kdemultimedia-3.1.4 which uses linux/linux.h - if it does matter.
-- 
--= Michal Kochanowicz =--==--==BOFH==--==--= michal@michal.waw.pl =--
--= finger me for PGP public key or visit http://michal.waw.pl/PGP =--
--==--==--==--==--==-- Vodka. Connecting people.--==--==--==--==--==--
A chodzenie po górach SSIE!!!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6.0-test6] definition and usage of __u64/__s64 inconsistent?
  2003-10-03  8:54 [2.6.0-test6] definition and usage of __u64/__s64 inconsistent? Michal Kochanowicz
@ 2003-10-03  9:03 ` David S. Miller
  2003-10-03 18:12   ` Michal Kochanowicz
  0 siblings, 1 reply; 3+ messages in thread
From: David S. Miller @ 2003-10-03  9:03 UTC (permalink / raw)
  To: Michal Kochanowicz; +Cc: linux-kernel

On Fri, 3 Oct 2003 10:54:12 +0200
Michal Kochanowicz <michal@michal.waw.pl> wrote:

> The file asm/types.h is _unconditionally_ included from linux/cdrom.h
> and linux/loop.h and both files use __u64 unonditionally. Isn't this an
> error?

Not really.

We could fix this by using the __extension__ keyword and thereby
get rid of the __STRICT_ANSI__ check and situations like your's
would work.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6.0-test6] definition and usage of __u64/__s64 inconsistent?
  2003-10-03  9:03 ` David S. Miller
@ 2003-10-03 18:12   ` Michal Kochanowicz
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Kochanowicz @ 2003-10-03 18:12 UTC (permalink / raw)
  To: David S. Miller; +Cc: linux-kernel

On Fri, Oct 03, 2003 at 02:03:17AM -0700, David S. Miller wrote:
> Not really.
> 
> We could fix this by using the __extension__ keyword and thereby
> get rid of the __STRICT_ANSI__ check and situations like your's
> would work.
OK, then question is: will you fix it? Or maybe it's application which
should be fixed (how?) ?
-- 
--= Michal Kochanowicz =--==--==BOFH==--==--= michal@michal.waw.pl =--
--= finger me for PGP public key or visit http://michal.waw.pl/PGP =--
--==--==--==--==--==-- Vodka. Connecting people.--==--==--==--==--==--
A chodzenie po górach SSIE!!!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-10-03 18:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-10-03  8:54 [2.6.0-test6] definition and usage of __u64/__s64 inconsistent? Michal Kochanowicz
2003-10-03  9:03 ` David S. Miller
2003-10-03 18:12   ` Michal Kochanowicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox