Re: [PATCH] linuxabi

Bernd Eckenfels
2003-10-01T02:06:28Z

In article <UTC200310010001.h9101NU17078.aeb@smtp.cwi.nl> you wrote:
> +These headers are "append-only", in the sense that Linux
> +tries to keep supporting old interfaces.

I dont think this is true. Neighter was is true in the past nor is it
desireable in all cases. We may define a range of releases, where the ABI
will be stable, but I am not sure we find a text everybody agrees on.

I do think it is not a bead idea to keep deprecated values at least
commented out, to avoid reuse, whenever possible.

Otherwise I love the idea. Have you checked back with the Glibc folks?

> +#define MS_NODIRATIME 2048 /* Do not update directory access times */
> +#define MS_BIND 4096
> +#define MS_POSIXACL (1<<16) /* VFS does not apply the umask */

can we clean that up? with shifting, without shifting, with comments and without comments? I suggest to use the linuxdoc comments mandatory for the abi files.

> + * Old magic mount flag and mask

i also suggest to think twice about using the word old somewhere.
valid-since, deprecated-after may be used in conjunction with version
identifiers. And not including deprecated symbols is also a good start.

Greetings
Bernd
--
eckes privat - http://www.eckes.org/
Project Freefire - http://www.freefire.org/