From: Patrick Mansfield <patmans@us.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux1394-devel@lists.sourceforge.net
Subject: Re: oops when removing sbp2 module
Date: Sun, 5 Oct 2003 20:36:06 -0700 [thread overview]
Message-ID: <20031005203606.A3829@beaverton.ibm.com> (raw)
In-Reply-To: <16256.56491.671416.205944@cargo.ozlabs.ibm.com>; from paulus@samba.org on Mon, Oct 06, 2003 at 01:08:27PM +1000
On Mon, Oct 06, 2003 at 01:08:27PM +1000, Paul Mackerras wrote:
> That fixes it, it no longer oopses on removing sbp2. As before I get
> a message saying "Device 'fw-host0' does not have a release()
> function, it is broken and must be fixed." I assume that is a problem
> with the sbp2 module.
>
> The code in the patch looks a little worrying to me, though. Is there
> some lock we have taken to ensure that no other process could be
> modifying sdev->access_count at the same time? Also, what is to stop
> some other process from noticing that sdev->access_count is 0 and
> calling device_del(&sdev->sdev_gendev) ?
Yes, it's a known problem, there is also a comment in the code, Christoph
was working on it.
-- Patrick Mansfield
prev parent reply other threads:[~2003-10-06 3:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-05 13:12 oops when removing sbp2 module Paul Mackerras
2003-10-05 14:49 ` Patrick Mansfield
2003-10-06 3:08 ` Paul Mackerras
2003-10-06 3:36 ` Patrick Mansfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031005203606.A3829@beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox