[PATCH 2.6] Warnings in 8250_acpi

[PATCH 2.6] Warnings in 8250_acpi

[Dmitry Torokhov]

Lastest changes in 8250_acpi.c produce warnings about type mismatch
in printk. We could either change format to print long long arguments
or, until most of us are on 64 bits, just trim values to 32.

Dmitry

--- 1.3/drivers/serial/8250_acpi.c      Wed Oct  1 04:11:17 2003
+++ edited/drivers/serial/8250_acpi.c   Mon Oct  6 01:18:22 2003
@@ -28,8 +28,9 @@
        req->iomem_base = ioremap(req->iomap_base, size);
        if (!req->iomem_base) {
                printk(KERN_ERR "%s: couldn't ioremap 0x%lx-0x%lx\n",
-                       __FUNCTION__, addr->min_address_range,
-                       addr->max_address_range);
+                       __FUNCTION__,
+                       (unsigned long)addr->min_address_range,
+                       (unsigned long)addr->max_address_range);
                return AE_ERROR;
        }
        req->io_type = SERIAL_IO_MEM;

Re: [PATCH 2.6] Warnings in 8250_acpi

[Russell King]

On Mon, Oct 06, 2003 at 01:31:55AM -0500, Dmitry Torokhov wrote:
> Lastest changes in 8250_acpi.c produce warnings about type mismatch
> in printk. We could either change format to print long long arguments
> or, until most of us are on 64 bits, just trim values to 32.

I'd like Bjorn to comment before I apply this.

--- 1.3/drivers/serial/8250_acpi.c      Wed Oct  1 04:11:17 2003
+++ edited/drivers/serial/8250_acpi.c   Mon Oct  6 01:18:22 2003
@@ -28,8 +28,9 @@
        req->iomem_base = ioremap(req->iomap_base, size);
        if (!req->iomem_base) {
                printk(KERN_ERR "%s: couldn't ioremap 0x%lx-0x%lx\n",
-                       __FUNCTION__, addr->min_address_range,
-                       addr->max_address_range);
+                       __FUNCTION__,
+                       (unsigned long)addr->min_address_range,
+                       (unsigned long)addr->max_address_range);
                return AE_ERROR;
        }
        req->io_type = SERIAL_IO_MEM;

-- 
Russell King (rmk@arm.linux.org.uk)	http://www.arm.linux.org.uk/personal/
      Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
      maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                      2.6 Serial core

Re: [PATCH 2.6] Warnings in 8250_acpi

[Bjorn Helgaas]

On Monday 06 October 2003 2:38 am, Russell King wrote:
> On Mon, Oct 06, 2003 at 01:31:55AM -0500, Dmitry Torokhov wrote:
> > Lastest changes in 8250_acpi.c produce warnings about type mismatch
> > in printk. We could either change format to print long long arguments
> > or, until most of us are on 64 bits, just trim values to 32.
> 
> I'd like Bjorn to comment before I apply this.

Oops, sorry about that.  Here's my preference for fixing it:

===== drivers/serial/8250_acpi.c 1.3 vs edited =====
--- 1.3/drivers/serial/8250_acpi.c	Wed Oct  1 03:11:17 2003
+++ edited/drivers/serial/8250_acpi.c	Mon Oct  6 12:33:54 2003
@@ -28,8 +28,7 @@
 	req->iomem_base = ioremap(req->iomap_base, size);
 	if (!req->iomem_base) {
 		printk(KERN_ERR "%s: couldn't ioremap 0x%lx-0x%lx\n",
-			__FUNCTION__, addr->min_address_range,
-			addr->max_address_range);
+			__FUNCTION__, req->iomap_base, req->iomap_base + size);
 		return AE_ERROR;
 	}
 	req->io_type = SERIAL_IO_MEM;