From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Russell King <rmk@arm.linux.org.uk>,
Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6] Warnings in 8250_acpi
Date: Mon, 6 Oct 2003 10:07:36 -0600 [thread overview]
Message-ID: <200310061007.36240.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <20031006093811.A12713@flint.arm.linux.org.uk>
On Monday 06 October 2003 2:38 am, Russell King wrote:
> On Mon, Oct 06, 2003 at 01:31:55AM -0500, Dmitry Torokhov wrote:
> > Lastest changes in 8250_acpi.c produce warnings about type mismatch
> > in printk. We could either change format to print long long arguments
> > or, until most of us are on 64 bits, just trim values to 32.
>
> I'd like Bjorn to comment before I apply this.
Oops, sorry about that. Here's my preference for fixing it:
===== drivers/serial/8250_acpi.c 1.3 vs edited =====
--- 1.3/drivers/serial/8250_acpi.c Wed Oct 1 03:11:17 2003
+++ edited/drivers/serial/8250_acpi.c Mon Oct 6 12:33:54 2003
@@ -28,8 +28,7 @@
req->iomem_base = ioremap(req->iomap_base, size);
if (!req->iomem_base) {
printk(KERN_ERR "%s: couldn't ioremap 0x%lx-0x%lx\n",
- __FUNCTION__, addr->min_address_range,
- addr->max_address_range);
+ __FUNCTION__, req->iomap_base, req->iomap_base + size);
return AE_ERROR;
}
req->io_type = SERIAL_IO_MEM;
prev parent reply other threads:[~2003-10-06 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-06 6:31 [PATCH 2.6] Warnings in 8250_acpi Dmitry Torokhov
2003-10-06 8:38 ` Russell King
2003-10-06 16:07 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200310061007.36240.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox