From: Jens Axboe <axboe@suse.de>
To: Felipe W Damasio <felipewd@terra.com.br>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Cciss-discuss@lists.sourceforge.net
Subject: Re: [PATCH] release_region in cciss block driver
Date: Mon, 6 Oct 2003 15:42:25 +0200 [thread overview]
Message-ID: <20031006134225.GA972@suse.de> (raw)
In-Reply-To: <3F816DE5.8060009@terra.com.br>
On Mon, Oct 06 2003, Felipe W Damasio wrote:
> Hi Andrew,
>
> Patch against 2.6.0-test6.
>
> Release a previous requested region if we're about the fail the
> board initialization. Found by smatch.
>
> Please review and consider applying,
>
> Thanks.
>
> Felipe
> --- linux-2.6.0-test6/drivers/block/cciss.c.orig 2003-10-06 10:18:01.000000000 -0300
> +++ linux-2.6.0-test6/drivers/block/cciss.c 2003-10-06 10:25:04.000000000 -0300
> @@ -2185,6 +2185,7 @@
> schedule_timeout(HZ / 10); /* wait 100ms */
> }
> if (scratchpad != CCISS_FIRMWARE_READY) {
> + release_io_mem (c);
> printk(KERN_WARNING "cciss: Board not ready. Timed out.\n");
> return -1;
> }
Please at least try and follow the local style when you make changes.
--
Jens Axboe
next prev parent reply other threads:[~2003-10-06 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-06 13:28 [PATCH] release_region in cciss block driver Felipe W Damasio
2003-10-06 13:42 ` Jens Axboe [this message]
2003-10-06 13:55 ` Felipe W Damasio
2003-10-13 0:15 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031006134225.GA972@suse.de \
--to=axboe@suse.de \
--cc=Cciss-discuss@lists.sourceforge.net \
--cc=akpm@osdl.org \
--cc=felipewd@terra.com.br \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox