* [PATCH] release_region in cciss block driver
@ 2003-10-06 13:28 Felipe W Damasio
2003-10-06 13:42 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Felipe W Damasio @ 2003-10-06 13:28 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux Kernel Mailing List, Cciss-discuss
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
Hi Andrew,
Patch against 2.6.0-test6.
Release a previous requested region if we're about the fail the board
initialization. Found by smatch.
Please review and consider applying,
Thanks.
Felipe
[-- Attachment #2: cciss-region.patch --]
[-- Type: text/plain, Size: 388 bytes --]
--- linux-2.6.0-test6/drivers/block/cciss.c.orig 2003-10-06 10:18:01.000000000 -0300
+++ linux-2.6.0-test6/drivers/block/cciss.c 2003-10-06 10:25:04.000000000 -0300
@@ -2185,6 +2185,7 @@
schedule_timeout(HZ / 10); /* wait 100ms */
}
if (scratchpad != CCISS_FIRMWARE_READY) {
+ release_io_mem (c);
printk(KERN_WARNING "cciss: Board not ready. Timed out.\n");
return -1;
}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] release_region in cciss block driver
2003-10-06 13:28 [PATCH] release_region in cciss block driver Felipe W Damasio
@ 2003-10-06 13:42 ` Jens Axboe
2003-10-06 13:55 ` Felipe W Damasio
0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2003-10-06 13:42 UTC (permalink / raw)
To: Felipe W Damasio; +Cc: Andrew Morton, Linux Kernel Mailing List, Cciss-discuss
On Mon, Oct 06 2003, Felipe W Damasio wrote:
> Hi Andrew,
>
> Patch against 2.6.0-test6.
>
> Release a previous requested region if we're about the fail the
> board initialization. Found by smatch.
>
> Please review and consider applying,
>
> Thanks.
>
> Felipe
> --- linux-2.6.0-test6/drivers/block/cciss.c.orig 2003-10-06 10:18:01.000000000 -0300
> +++ linux-2.6.0-test6/drivers/block/cciss.c 2003-10-06 10:25:04.000000000 -0300
> @@ -2185,6 +2185,7 @@
> schedule_timeout(HZ / 10); /* wait 100ms */
> }
> if (scratchpad != CCISS_FIRMWARE_READY) {
> + release_io_mem (c);
> printk(KERN_WARNING "cciss: Board not ready. Timed out.\n");
> return -1;
> }
Please at least try and follow the local style when you make changes.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] release_region in cciss block driver
2003-10-06 13:42 ` Jens Axboe
@ 2003-10-06 13:55 ` Felipe W Damasio
2003-10-13 0:15 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Felipe W Damasio @ 2003-10-06 13:55 UTC (permalink / raw)
To: Jens Axboe; +Cc: Andrew Morton, Linux Kernel Mailing List, Cciss-discuss
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
Jens Axboe wrote:
> Please at least try and follow the local style when you make changes.
Right, sorry.
Andrew, please use this patch instead.
Felipe
[-- Attachment #2: cciss-region.patch --]
[-- Type: text/plain, Size: 387 bytes --]
--- linux-2.6.0-test6/drivers/block/cciss.c.orig 2003-10-06 10:18:01.000000000 -0300
+++ linux-2.6.0-test6/drivers/block/cciss.c 2003-10-06 10:25:04.000000000 -0300
@@ -2185,6 +2185,7 @@
schedule_timeout(HZ / 10); /* wait 100ms */
}
if (scratchpad != CCISS_FIRMWARE_READY) {
+ release_io_mem(c);
printk(KERN_WARNING "cciss: Board not ready. Timed out.\n");
return -1;
}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] release_region in cciss block driver
2003-10-06 13:55 ` Felipe W Damasio
@ 2003-10-13 0:15 ` Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2003-10-13 0:15 UTC (permalink / raw)
To: Felipe W Damasio; +Cc: axboe, linux-kernel, Cciss-discuss
Felipe W Damasio <felipewd@terra.com.br> wrote:
>
> --- linux-2.6.0-test6/drivers/block/cciss.c.orig 2003-10-06 10:18:01.000000000 -0300
> +++ linux-2.6.0-test6/drivers/block/cciss.c 2003-10-06 10:25:04.000000000 -0300
> @@ -2185,6 +2185,7 @@
> schedule_timeout(HZ / 10); /* wait 100ms */
> }
> if (scratchpad != CCISS_FIRMWARE_READY) {
> + release_io_mem(c);
> printk(KERN_WARNING "cciss: Board not ready. Timed out.\n");
> return -1;
> }
It seems to me that the driver is already performing this function
in the caller.
static int __devinit cciss_init_one(struct pci_dev *pdev,
const struct pci_device_id *ent)
{
...
if (cciss_pci_init(hba[i], pdev) != 0)
goto clean1;
...
clean1:
release_io_mem(hba[i]);
free_hba(i);
return(-1);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-10-13 0:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-10-06 13:28 [PATCH] release_region in cciss block driver Felipe W Damasio
2003-10-06 13:42 ` Jens Axboe
2003-10-06 13:55 ` Felipe W Damasio
2003-10-13 0:15 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox