public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, zaitcev@redhat.com,
	Florian La Roche <laroche@redhat.com>
Subject: Re: s390 test6 patches: descriptions.
Date: Mon, 6 Oct 2003 13:54:16 -0400	[thread overview]
Message-ID: <20031006135416.B16665@devserv.devel.redhat.com> (raw)
In-Reply-To: <mailman.1065432601.831.linux-kernel2news@redhat.com>; from schwidefsky@de.ibm.com on Mon, Oct 06, 2003 at 11:23:52AM +0200

> more patches for s390. 7 this time, one is big and another one is VERY big.

This is all fine, but the removal of dst_link_failure is missing.
Why is that? We agreed about it several update cycles before.
I am not doing because I'm bored, we hit actual oopses (ok, on 2.4).

-- Pete

diff -urN -X dontdiff linux-2.6.0-test6/drivers/s390/net/ctcmain.c linux-2.6.0-test6-s390/drivers/s390/net/ctcmain.c
--- linux-2.6.0-test6/drivers/s390/net/ctcmain.c	2003-10-01 15:17:54.000000000 -0700
+++ linux-2.6.0-test6-s390/drivers/s390/net/ctcmain.c	2003-10-01 15:31:17.000000000 -0700
@@ -2441,14 +2441,12 @@
 
 	/**
 	 * If channels are not running, try to restart them
-	 * notify anybody about a link failure and throw
-	 * away packet. 
+	 * and throw away packet. 
 	 */
 	if (fsm_getstate(privptr->fsm) != DEV_STATE_RUNNING) {
 		fsm_event(privptr->fsm, DEV_EVENT_START, dev);
 		if (privptr->protocol == CTC_PROTO_LINUX_TTY)
 			return -EBUSY;
-		dst_link_failure(skb);
 		dev_kfree_skb(skb);
 		privptr->stats.tx_dropped++;
 		privptr->stats.tx_errors++;
diff -urN -X dontdiff linux-2.6.0-test6/drivers/s390/net/netiucv.c linux-2.6.0-test6-s390/drivers/s390/net/netiucv.c
--- linux-2.6.0-test6/drivers/s390/net/netiucv.c	2003-10-01 15:17:54.000000000 -0700
+++ linux-2.6.0-test6-s390/drivers/s390/net/netiucv.c	2003-10-01 15:31:17.000000000 -0700
@@ -1177,12 +1177,10 @@
 
 	/**
 	 * If connection is not running, try to restart it
-	 * notify anybody about a link failure and throw
-	 * away packet. 
+	 * and throw away packet. 
 	 */
 	if (fsm_getstate(privptr->fsm) != DEV_STATE_RUNNING) {
 		fsm_event(privptr->fsm, DEV_EVENT_START, dev);
-		dst_link_failure(skb);
 		dev_kfree_skb(skb);
 		privptr->stats.tx_dropped++;
 		privptr->stats.tx_errors++;
diff -urN -X dontdiff linux-2.6.0-test6/drivers/s390/net/qeth.c linux-2.6.0-test6-s390/drivers/s390/net/qeth.c
--- linux-2.6.0-test6/drivers/s390/net/qeth.c	2003-10-01 15:17:54.000000000 -0700
+++ linux-2.6.0-test6-s390/drivers/s390/net/qeth.c	2003-10-01 15:36:16.000000000 -0700
@@ -1996,7 +1996,6 @@
 			case ERROR_LINK_FAILURE:
 			case ERROR_KICK_THAT_PUPPY:
 				QETH_DBF_TEXT4(0, trace, "endeglnd");
-				dst_link_failure(skb);
 				atomic_dec(&skb->users);
 				dev_kfree_skb_irq(skb);
 				break;
@@ -2489,7 +2488,6 @@
 
 	if (!card) {
 		QETH_DBF_TEXT2(0, trace, "XMNSNOCD");
-		dst_link_failure(skb);
 		dev_kfree_skb_irq(skb);
 		return 0;
 	}
@@ -2501,7 +2499,6 @@
 		card->stats->tx_carrier_errors++;
 		QETH_DBF_TEXT2(0, trace, "XMNS");
 		QETH_DBF_TEXT2(0, trace, card->rdev->dev.bus_id);
-		dst_link_failure(skb);
 		dev_kfree_skb_irq(skb);
 		return 0;
 	}

  parent reply	other threads:[~2003-10-06 17:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.1065432601.831.linux-kernel2news@redhat.com>
2003-10-06 17:50 ` s390 test6 patches: descriptions Pete Zaitcev
2003-10-06 17:54 ` Pete Zaitcev [this message]
2003-10-06 18:01 ` Pete Zaitcev
2003-10-06 18:38 Martin Schwidefsky
  -- strict thread matches above, loose matches on Subject: below --
2003-10-06 18:21 Martin Schwidefsky
2003-10-06  9:23 Martin Schwidefsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031006135416.B16665@devserv.devel.redhat.com \
    --to=zaitcev@redhat.com \
    --cc=laroche@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox