From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262259AbTJFOoz (ORCPT ); Mon, 6 Oct 2003 10:44:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262260AbTJFOoy (ORCPT ); Mon, 6 Oct 2003 10:44:54 -0400 Received: from pub234.cambridge.redhat.com ([213.86.99.234]:28177 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S262259AbTJFOox (ORCPT ); Mon, 6 Oct 2003 10:44:53 -0400 Date: Mon, 6 Oct 2003 15:44:51 +0100 From: Christoph Hellwig To: Martin Schwidefsky Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org Subject: Re: [PATCH] s390 (2/7): common i/o layer. Message-ID: <20031006154451.A20620@infradead.org> Mail-Followup-To: Christoph Hellwig , Martin Schwidefsky , linux-kernel@vger.kernel.org, torvalds@osdl.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from schwidefsky@de.ibm.com on Mon, Oct 06, 2003 at 04:40:06PM +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 06, 2003 at 04:40:06PM +0200, Martin Schwidefsky wrote: > > Hi Christoph, > > > Eek. How is the dummy release function supposed to help > > anything? you must free the object in ->release. Also > > the assignment is horrible as hell. > > Just checked. You right about chp_release which should do > a kfree on the struct channel_path object. But the two > other release functions are really dummy functions because > cu3088_root_dev and iucv_root are static structures. Even in that case you're screwed in case they are in modules..