From: Pete Zaitcev <zaitcev@redhat.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390 (6/7): qeth driver.
Date: Mon, 6 Oct 2003 13:42:47 -0400 [thread overview]
Message-ID: <200310061742.h96Hglq15920@devserv.devel.redhat.com> (raw)
In-Reply-To: <mailman.1065433200.1921.linux-kernel2news@redhat.com>
> PRINT_WARN("received an IDX TERMINATE on device %s "
> "with cause code 0x%02x%s\n",
> - card->rdev->dev.bus_id, buffer[4],
> + CARD_BUS_ID(card), buffer[4],
> (buffer[4] ==
> 0x22) ? " -- try another portname" : "");
> #define PROBLEM_TX_TIMEOUT 12
>
> +#define CARD_RDEV(card) card->gdev->cdev[0]
> +#define CARD_WDEV(card) card->gdev->cdev[1]
> +#define CARD_DDEV(card) card->gdev->cdev[2]
> +#define CARD_BUS_ID(card) card->gdev->dev.bus_id
> +#define CARD_RDEV_ID(card) card->gdev->cdev[0]->dev.bus_id
> +#define CARD_WDEV_ID(card) card->gdev->cdev[1]->dev.bus_id
> +#define CARD_DDEV_ID(card) card->gdev->cdev[2]->dev.bus_id
IMHO, this meaningless hiding is poorly concieved and
was discredited by its usage in UNIX. I object. On paper
is sounds fine, allowing to change implementation details
underneath the macro, yada yada. In practice, it adds
unnecessary opaquity.
-- Pete
next parent reply other threads:[~2003-10-06 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1065433200.1921.linux-kernel2news@redhat.com>
2003-10-06 17:42 ` Pete Zaitcev [this message]
2003-10-06 9:27 [PATCH] s390 (6/7): qeth driver Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200310061742.h96Hglq15920@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox