From: Matthew Wilcox <willy@debian.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Mark Haverkamp <markh@osdl.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] 2.6.0 aacraid driver update
Date: Mon, 6 Oct 2003 22:59:36 +0100 [thread overview]
Message-ID: <20031006215936.GF24824@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <3F81E34A.1040201@pobox.com>
On Mon, Oct 06, 2003 at 05:48:58PM -0400, Jeff Garzik wrote:
> >+ /*
> >+ * Yield the processor in case we are slow
> >+ */
> >+ set_current_state(TASK_UNINTERRUPTIBLE);
> >+ schedule_timeout(1);
>
> hmmm... why not simply call yield() here instead? I think yield() is
> closer to the intent you wish to achieve...
Gods, no. I believe it is always a bug for drivers to call yield()
in 2.6. What is probably meant here is cond_resched(). I'd support
deleting the EXPORT_SYMBOL(yield) line and fixing the breakage afterwards
as it causes lots of very subtle breakage ("Under certain circumstances,
Linux just stops doing anything for 5 seconds").
--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
next parent reply other threads:[~2003-10-06 21:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1065475285.17021.79.camel@markh1.pdx.osdl.net>
[not found] ` <3F81E34A.1040201@pobox.com>
2003-10-06 21:59 ` Matthew Wilcox [this message]
2003-10-06 22:06 ` [PATCH 3/3] 2.6.0 aacraid driver update Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031006215936.GF24824@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=markh@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox