From: Dave Jones <davej@redhat.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: paul.devriendt@amd.com,
kernel list <linux-kernel@vger.kernel.org>,
Rusty trivial patch monkey Russell <trivial@rustcorp.com.au>
Subject: Re: powernow-k8: don't crash system at boot
Date: Tue, 7 Oct 2003 17:03:47 +0100 [thread overview]
Message-ID: <20031007160346.GD29736@redhat.com> (raw)
In-Reply-To: <20031005190056.GA863@elf.ucw.cz>
On Sun, Oct 05, 2003 at 09:00:57PM +0200, Pavel Machek wrote:
<Please don't send these to Rusty, such changes are far from trivial.
Not that I don't trust Rusty to pass on them, but it's one less thing
he has to worry about..>
> powernow-k8 module fails to initialize government on boot, leading to
> nasty crash at boot.
See below.
> This fixes it. Plus find_closest_find really wants to be static. Fix
> it, too.
Applied. Thanks.
> @@ -971,6 +971,7 @@
> pol->cpuinfo.max_freq = 1000 * find_freq_from_fid(ppst[numps-1].fid);
> pol->min = 1000 * find_freq_from_fid(ppst[0].fid);
> pol->max = 1000 * find_freq_from_fid(ppst[batps - 1].fid);
> + pol->governor = CPUFREQ_DEFAULT_GOVERNOR;
>
> printk(KERN_INFO PFX "cpu_init done, current fid 0x%x, vid 0x%x\n",
> currfid, currvid);
Already fixed differently. Dominik's patch also nuked the setting of ->policy
a few lines above.
Dave
--
Dave Jones http://www.codemonkey.org.uk
next prev parent reply other threads:[~2003-10-07 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-05 19:00 powernow-k8: don't crash system at boot Pavel Machek
2003-10-07 16:03 ` Dave Jones [this message]
2003-10-07 16:12 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031007160346.GD29736@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.devriendt@amd.com \
--cc=pavel@ucw.cz \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox