From: Pavel Machek <pavel@suse.cz>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cleanup of compat_ioctl functions
Date: Wed, 8 Oct 2003 21:29:29 +0200 [thread overview]
Message-ID: <20031008192929.GC1035@elf.ucw.cz> (raw)
In-Reply-To: <200310081809.42859.arnd@arndb.de>
Hi!
> This is my reworked patch for cleaning up compat_ioctl, with the main
> purpose of making it usable for s390. Every single change here should
> be trivial, but there are a lot of them.
Looks good to me. [I just scanned it...]
Perhaps it compat_ptr_u32(arg), that returns (u32 __user *) should be
invented? [Well, its used only 3 times, so maybe this is bad idea].
Also __u32 should not be used here, it looks too ugly and u32 is
okay. Same for __u16 and __u64. Its simple search&replace, and as you
are doing lots of changes, anyway....
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2003-10-08 19:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 16:09 [PATCH] cleanup of compat_ioctl functions Arnd Bergmann
2003-10-08 19:29 ` Pavel Machek [this message]
2003-10-08 20:26 ` Arnd Bergmann
2003-10-08 21:02 ` David S. Miller
2003-10-08 21:35 ` Pavel Machek
2003-10-08 22:49 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031008192929.GC1035@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox