From: David Gibson <david@gibson.dropbear.id.au>
To: David Miller <davem@redhat.com>, Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: [TRIVIAL] Fix initialization sequence in SunGEM driver
Date: Thu, 9 Oct 2003 17:06:49 +1000 [thread overview]
Message-ID: <20031009070649.GA830@zax> (raw)
The patch below alters the SunGEM driver so that the net_device
callback pointers are initialized before calling register_netdev(),
rather than after.
I think that would always have been a bug, but its effects have become
worse in recent kernels: the fact that get_stats is NULL when
register_netdev() is called means that the netstat_group sysfs
attributes are not registered. That in turn means that we get an oops
on module remove as it attempts to deregister those attributes
(dir->d_inode is NULL in sysfs_hash_and_remove()).
diff -urN linuxppc-2.5-benh/drivers/net/sungem.c linux-zax/drivers/net/sungem.c
--- linuxppc-2.5-benh/drivers/net/sungem.c 2003-09-29 18:30:43.000000000 +1000
+++ linux-zax/drivers/net/sungem.c 2003-10-09 16:18:19.024186984 +1000
@@ -2757,6 +2757,19 @@
if (gem_get_device_address(gp))
goto err_out_free_consistent;
+ dev->open = gem_open;
+ dev->stop = gem_close;
+ dev->hard_start_xmit = gem_start_xmit;
+ dev->get_stats = gem_get_stats;
+ dev->set_multicast_list = gem_set_multicast;
+ dev->do_ioctl = gem_ioctl;
+ dev->ethtool_ops = &gem_ethtool_ops;
+ dev->tx_timeout = gem_tx_timeout;
+ dev->watchdog_timeo = 5 * HZ;
+ dev->change_mtu = gem_change_mtu;
+ dev->irq = pdev->irq;
+ dev->dma = 0;
+
if (register_netdev(dev)) {
printk(KERN_ERR PFX "Cannot register net device, "
"aborting.\n");
@@ -2785,19 +2798,6 @@
pci_set_drvdata(pdev, dev);
- dev->open = gem_open;
- dev->stop = gem_close;
- dev->hard_start_xmit = gem_start_xmit;
- dev->get_stats = gem_get_stats;
- dev->set_multicast_list = gem_set_multicast;
- dev->do_ioctl = gem_ioctl;
- dev->ethtool_ops = &gem_ethtool_ops;
- dev->tx_timeout = gem_tx_timeout;
- dev->watchdog_timeo = 5 * HZ;
- dev->change_mtu = gem_change_mtu;
- dev->irq = pdev->irq;
- dev->dma = 0;
-
/* GEM can do it all... */
dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM;
if (pci_using_dac)
--
David Gibson | For every complex problem there is a
david@gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
next reply other threads:[~2003-10-09 7:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-09 7:06 David Gibson [this message]
2003-10-10 6:56 ` [TRIVIAL] Fix initialization sequence in SunGEM driver David S. Miller
2003-10-24 3:30 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031009070649.GA830@zax \
--to=david@gibson.dropbear.id.au \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox