From: Pavel Machek <pavel@suse.cz>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Patrick Mochel <mochel@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [pm] Re: JFFS2 swsusp / signal cleanup.
Date: Thu, 9 Oct 2003 11:24:41 +0200 [thread overview]
Message-ID: <20031009092441.GA304@elf.ucw.cz> (raw)
In-Reply-To: <1065659366.30987.178.camel@imladris.demon.co.uk>
Hi!
> Do you need locking for recalc_sigpending()?
Hmm, seems so; btw your patch seems to miss it too:
> @@ -104,6 +105,13 @@
> schedule();
> }
>
> + if (current->flags & PF_FREEZE) {
> + refrigerator(0); /* When this loses its
> stupid flush_signals()
> + and starts just
> calling recalc_sigpending(),
> + you can remove the
> following: */
> + recalc_sigpending();
> + }
> +
> cond_resched();
>
> /* Put_super will send a SIGKILL and then wait on the
> sem.
I'll test it and send updated patch.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
prev parent reply other threads:[~2003-10-09 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-04 11:25 JFFS2 swsusp / signal cleanup David Woodhouse
2003-10-05 16:11 ` Pavel Machek
2003-10-05 16:19 ` Russell King
2003-10-05 19:13 ` Pavel Machek
2003-10-05 20:07 ` David Woodhouse
2003-10-09 0:23 ` [pm] " Pavel Machek
2003-10-09 0:29 ` David Woodhouse
2003-10-09 9:24 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031009092441.GA304@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox