From: "David S. Miller" <davem@redhat.com>
To: Ingo Oeser <ioe-lkml@rameria.de>
Cc: toby@cbcg.net, netdev@oss.sgi.com, linux-net@vger.kernel.org,
linux-kernel@vger.kernel.org, coreteam@netfilter.org,
netfilter@lists.netfilter.org, akpm@zip.com.au,
kuznet@ms2.inr.ac.ru, pekkas@netcore.fi,
jmorris@intercode.com.au, yoshfuji@linux-ipv6.org,
jgarzik@pobox.com
Subject: Re: [PATCH] kfree_skb() bug in 2.4.22
Date: Fri, 10 Oct 2003 06:00:50 -0700 [thread overview]
Message-ID: <20031010060050.057aab50.davem@redhat.com> (raw)
In-Reply-To: <200310101453.44353.ioe-lkml@rameria.de>
On Fri, 10 Oct 2003 14:53:44 +0200
Ingo Oeser <ioe-lkml@rameria.de> wrote:
> On Wednesday 08 October 2003 15:47, David S. Miller wrote:
> > On Wed, 08 Oct 2003 09:09:48 -0400
> >
> > Jeff Garzik <jgarzik@pobox.com> wrote:
> > > I would prefer that you fix your code instead, to not pass NULL to
> > > kfree_skb()...
> >
> > Absolutely, there is no valid reason to pass NULL into these
> > routines.
>
> Would you mind __attribute_nonnull__ for these functions, if we
> enable GCC 3.3 support for this[1]?
I would say yes, but why? All this attribute does is optimize
away tests for NULL which surprise surprise we don't have any
of in kfree_skb().
next prev parent reply other threads:[~2003-10-10 13:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 12:44 [PATCH] kfree_skb() bug in 2.4.22 Tobias DiPasquale
2003-10-08 13:09 ` Jeff Garzik
2003-10-08 13:47 ` David S. Miller
2003-10-10 12:53 ` Ingo Oeser
2003-10-10 13:00 ` David S. Miller [this message]
2003-10-10 15:43 ` Ingo Oeser
2003-10-10 16:57 ` Dan Kegel
2003-10-08 14:11 ` Tobias DiPasquale
2003-10-08 14:11 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031010060050.057aab50.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@zip.com.au \
--cc=coreteam@netfilter.org \
--cc=ioe-lkml@rameria.de \
--cc=jgarzik@pobox.com \
--cc=jmorris@intercode.com.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=netfilter@lists.netfilter.org \
--cc=pekkas@netcore.fi \
--cc=toby@cbcg.net \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox