From: Pavel Machek <pavel@ucw.cz>
To: Rusty trivial patch monkey Russell <trivial@rustcorp.com.au>,
kernel list <linux-kernel@vger.kernel.org>
Subject: failing unregister_ioctl32 is pretty fatal condition -- fix up message level
Date: Fri, 10 Oct 2003 12:03:53 +0200 [thread overview]
Message-ID: <20031010100353.GA5481@elf.ucw.cz> (raw)
Hi!
AFAICS, kernel is likely to crash if someone does said ioctl after
failed unregister. Please apply,
Pavel
Index: linux/drivers/ieee1394/video1394.c
===================================================================
--- linux.orig/drivers/ieee1394/video1394.c 2003-10-09 00:40:50.000000000 +0200
+++ linux/drivers/ieee1394/video1394.c 2003-09-09 12:59:48.000000000 +0200
@@ -1424,7 +1424,7 @@
ret |= unregister_ioctl32_conversion(VIDEO1394_IOC32_TALK_WAIT_BUFFER);
ret |= unregister_ioctl32_conversion(VIDEO1394_IOC32_LISTEN_POLL_BUFFER);
if (ret)
- PRINT_G(KERN_INFO, "Error unregistering ioctl32 translations");
+ PRINT_G(KERN_CRIT, "Error unregistering ioctl32 translations");
#endif
hpsb_unregister_protocol(&video1394_driver);
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
reply other threads:[~2003-10-10 10:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031010100353.GA5481@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox