* failing unregister_ioctl32 is pretty fatal condition -- fix up message level
@ 2003-10-10 10:03 Pavel Machek
0 siblings, 0 replies; only message in thread
From: Pavel Machek @ 2003-10-10 10:03 UTC (permalink / raw)
To: Rusty trivial patch monkey Russell, kernel list
Hi!
AFAICS, kernel is likely to crash if someone does said ioctl after
failed unregister. Please apply,
Pavel
Index: linux/drivers/ieee1394/video1394.c
===================================================================
--- linux.orig/drivers/ieee1394/video1394.c 2003-10-09 00:40:50.000000000 +0200
+++ linux/drivers/ieee1394/video1394.c 2003-09-09 12:59:48.000000000 +0200
@@ -1424,7 +1424,7 @@
ret |= unregister_ioctl32_conversion(VIDEO1394_IOC32_TALK_WAIT_BUFFER);
ret |= unregister_ioctl32_conversion(VIDEO1394_IOC32_LISTEN_POLL_BUFFER);
if (ret)
- PRINT_G(KERN_INFO, "Error unregistering ioctl32 translations");
+ PRINT_G(KERN_CRIT, "Error unregistering ioctl32 translations");
#endif
hpsb_unregister_protocol(&video1394_driver);
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-10-10 10:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-10-10 10:03 failing unregister_ioctl32 is pretty fatal condition -- fix up message level Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox