public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: "Noah J. Misch" <noah@caltech.edu>
Cc: "David S. Miller" <davem@redhat.com>,
	linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: Re: [PATCH] Make net/ipx/ipx_proc.c compile w/o CONFIG_PROC_FS
Date: Fri, 10 Oct 2003 13:03:09 -0300	[thread overview]
Message-ID: <20031010160309.GB11366@conectiva.com.br> (raw)
In-Reply-To: <Pine.GSO.4.58.0310092214280.25392@sue>

Em Thu, Oct 09, 2003 at 10:58:57PM -0700, Noah J. Misch escreveu:
> Hello Arnaldo,
> 
> This is a trivial patch against ipx_proc.c that allows it to compile with
> CONFIG_PROC_FS unset.  The patch simply makes ipx_proc.c include init.h
> unconditionally, which ensures that __init and __exit are always defined.
> 
> This patch depends upon the patch "Make linux/init.h include linux/compiler.h",
> which I have CC-ed to all recipients of this patch.  Should Linus decline that
> patch, I can make the trivial changes necessary to make this patch work on its
> own, if you wish.
> 
> Thanks,
> Noah

I don't have any problem with this patch, Dave, could you please apply it?

- Arnaldo
 
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1342  -> 1.1343
#	  net/ipx/ipx_proc.c	1.9     -> 1.10
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/10/10	noah@caltech.edu	1.1343
# This file needs the __init macro in all cases, so include init.h
# regardless of CONFIG_PROC_FS.  This fixes a compilation error in
# the absence of CONFIG_PROC_FS.
# --------------------------------------------
#
diff -Nru a/net/ipx/ipx_proc.c b/net/ipx/ipx_proc.c
--- a/net/ipx/ipx_proc.c	Fri Oct 10 01:05:06 2003
+++ b/net/ipx/ipx_proc.c	Fri Oct 10 01:05:06 2003
@@ -5,8 +5,8 @@
  */

 #include <linux/config.h>
-#ifdef CONFIG_PROC_FS
 #include <linux/init.h>
+#ifdef CONFIG_PROC_FS
 #include <linux/proc_fs.h>
 #include <linux/spinlock.h>
 #include <linux/seq_file.h>

  reply	other threads:[~2003-10-10 15:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-10  5:58 [PATCH] Make net/ipx/ipx_proc.c compile w/o CONFIG_PROC_FS Noah J. Misch
2003-10-10 16:03 ` Arnaldo Carvalho de Melo [this message]
2003-10-11 19:14   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031010160309.GB11366@conectiva.com.br \
    --to=acme@conectiva.com.br \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=noah@caltech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox