public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Jens Axboe <axboe@suse.de>
Cc: Dave Jones <davej@redhat.com>, Jeff Garzik <jgarzik@pobox.com>,
	marcelo.tosatti@cyclades.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] laptop mode
Date: Sat, 11 Oct 2003 13:49:14 +0200	[thread overview]
Message-ID: <20031011114913.GA516@elf.ucw.cz> (raw)
In-Reply-To: <20031009142632.GI1232@suse.de>

Hi!

> > Right now laptopmode/aam is just a suspect. There are still 1-2 other
> > small patches against IDE which could be the reason.  We've dropped
> > laptopmode/aam for the time being to see if the folks seeing repeatable
> > corruption suddenly start behaving again.
> 
> aam patch is far more risky, it's a far more likely suspect. That patch
> never reall did go out of beta. Dropping laptop-mode and aam at the same
> time is bad engineering practice :).
> 
> laptop-mode cannot cause corruption that cannot show otherwise.

Well, if fireballs have data-corrupting that happens just after spinup
(for example), I can see how laptop-mode affects that. W/o
laptop-mode, disk is spinning all the time so sleep bugs can not
manifest themselves. You add laptop-mode, and...
								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]

  reply	other threads:[~2003-10-11 11:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200310091103.h99B31ug014566@hera.kernel.org>
2003-10-09 14:02 ` [PATCH] laptop mode Jeff Garzik
2003-10-09 14:05   ` Jens Axboe
2003-10-09 14:17     ` Dave Jones
2003-10-09 14:26       ` Jens Axboe
2003-10-11 11:49         ` Pavel Machek [this message]
2003-10-11 13:59           ` Jens Axboe
2003-10-12 22:45             ` Barry K. Nathan
2003-10-14 17:50               ` Jeff Garzik
2003-10-09 14:09   ` Marcelo Tosatti
2003-10-09 14:11     ` Jens Axboe
2003-10-09 14:18       ` Jeff Garzik
2003-10-09 14:21         ` Jens Axboe
2003-10-09 14:28       ` Dave Jones
2003-10-17 19:42       ` Jan Rychter
2003-10-18 12:52         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031011114913.GA516@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=axboe@suse.de \
    --cc=davej@redhat.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox