From: Jens Axboe <axboe@suse.de>
To: Andi Kleen <ak@colin2.muc.de>
Cc: Andi Kleen <ak@muc.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ide barrier support, #2
Date: Tue, 14 Oct 2003 17:12:30 +0200 [thread overview]
Message-ID: <20031014151230.GS1107@suse.de> (raw)
In-Reply-To: <20031014150807.GA99122@colin2.muc.de>
On Tue, Oct 14 2003, Andi Kleen wrote:
> > Uh be careful! It must be WRITEBARRIER, not WRITESYNC. I think I'll kill
> > WRITEBARRIER and just call it WRITESYNC, it's more logical. I've added
> > the modified variant, thanks.
>
> Why? The journaling just checks if the write finished and then submits
> the dependent writes. It doesn't care about reordering.
See the patch, WRITESYNC is used solely internally in raid1.
WRITEBARRIER is a bitmask of BIO_RW and BIO_RW_BARRIER and that is what
you want. I'll make that more clear. Writes will not be reordered around
the barrier either, btw.
> As long as WRITESYNC guarantees that the data hit disk when completed
> then it should be ok.
Yep.
--
Jens Axboe
next prev parent reply other threads:[~2003-10-14 15:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <GurO.7cg.43@gated-at.bofh.it>
2003-10-14 12:53 ` [PATCH] ide barrier support, #2 Andi Kleen
2003-10-14 12:57 ` Jens Axboe
2003-10-14 15:08 ` Andi Kleen
2003-10-14 15:12 ` Jens Axboe [this message]
2003-10-14 15:28 ` Andi Kleen
2003-10-14 15:31 ` Jens Axboe
2003-10-14 10:15 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031014151230.GS1107@suse.de \
--to=axboe@suse.de \
--cc=ak@colin2.muc.de \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox