From: Thomas Schlichter <schlicht@uni-mannheim.de>
To: len.brown@intel.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH][2.4] fix "pci=noacpi" boot option
Date: Tue, 14 Oct 2003 23:28:58 +0200 [thread overview]
Message-ID: <200310142328.59083.schlicht@uni-mannheim.de> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 539 bytes --]
Hi Len,
some time ago I sent a patch which fixed problems with the "pci=noacpi" boot
option of the 2.5.xx linux-kernel. It got applied to the 2.5 kernel tree but
I missed to create a similar fix for the 2.4 tree which seems to have the
same issue.
Now I've seen reports of people having problems with the "pci=noacpi" boot
option with current 2.4.xx kernel versions, too. So I ported my old patch to
2.4.22-bk34, tested it and attached it to this mail. You may consider pushing
it to Marcelo.
Kind regards,
Thomas
[-- Attachment #1.2: fix_pci_noacpi.diff --]
[-- Type: text/x-diff, Size: 1176 bytes --]
--- linux-2.4.22-bk34/arch/i386/kernel/acpi.c.orig Tue Oct 14 20:50:18 2003
+++ linux-2.4.22-bk34/arch/i386/kernel/acpi.c Tue Oct 14 20:53:45 2003
@@ -58,6 +58,7 @@
#ifdef CONFIG_ACPI_BOOT
extern int acpi_disabled;
+extern int acpi_irq;
extern int acpi_ht;
enum acpi_irq_model_id acpi_irq_model;
@@ -415,7 +416,7 @@
* If MPS is present, it will handle them,
* otherwise the system will stay in PIC mode
*/
- if (acpi_disabled) {
+ if (acpi_disabled || !acpi_irq) {
return 1;
}
--- linux-2.4.22-bk34/arch/i386/kernel/setup.c.orig Tue Oct 14 20:50:25 2003
+++ linux-2.4.22-bk34/arch/i386/kernel/setup.c Tue Oct 14 20:57:34 2003
@@ -184,6 +184,7 @@
EXPORT_SYMBOL(acpi_disabled);
#ifdef CONFIG_ACPI_BOOT
+ int acpi_irq __initdata = 1; /* enable IRQ */
int acpi_ht __initdata = 1; /* enable HT */
#endif
@@ -848,6 +849,11 @@
else if (!memcmp(from, "acpi=ht", 7)) {
acpi_ht = 1;
if (!acpi_force) acpi_disabled = 1;
+ }
+
+ /* "pci=noacpi" disables ACPI interrupt routing */
+ else if (!memcmp(from, "pci=noacpi", 10)) {
+ acpi_irq = 0;
}
/* disable IO-APIC */
[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2003-10-14 21:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-14 21:28 Thomas Schlichter [this message]
2003-10-21 3:32 ` [PATCH][2.4] fix "pci=noacpi" boot option Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200310142328.59083.schlicht@uni-mannheim.de \
--to=schlicht@uni-mannheim.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox