From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262439AbTJOGp4 (ORCPT ); Wed, 15 Oct 2003 02:45:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262441AbTJOGp4 (ORCPT ); Wed, 15 Oct 2003 02:45:56 -0400 Received: from twilight.ucw.cz ([81.30.235.3]:4036 "EHLO twilight.ucw.cz") by vger.kernel.org with ESMTP id S262439AbTJOGpy (ORCPT ); Wed, 15 Oct 2003 02:45:54 -0400 Date: Wed, 15 Oct 2003 08:45:48 +0200 From: Vojtech Pavlik To: Eric Wong Cc: Vojtech Pavlik , 4Front Technologies , Martin Josefsson , linux-kernel@vger.kernel.org Subject: Re: mouse driver bug in 2.6.0-test7? Message-ID: <20031015064548.GA11788@ucw.cz> References: <3F8C3A99.6020106@opensound.com> <1066159113.12171.4.camel@tux.rsn.bth.se> <20031014193847.GA9112@ucw.cz> <3F8C56B3.1080504@opensound.com> <20031014201354.GA10458@ucw.cz> <20031015004837.GA444@BL4ST> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031015004837.GA444@BL4ST> User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 15, 2003 at 12:48:37AM +0000, Eric Wong wrote: > Vojtech Pavlik wrote: > > On Tue, Oct 14, 2003 at 01:04:03PM -0700, 4Front Technologies wrote: > > > I'd recommend that you make the sample rate a module config option so that > > > users may be able to tweak this for their systems. > > > > It already is. Only the code to make it a kernel command line parameter > > (when psmouse is compiled into the kernel) is missing. > > I could've sworn I had this in one of the patches I sent you, but > perhaps not. Most likely you did. I'll be making a fix-only patch set for Linus today. > --- drivers/input/mouse/psmouse-base.c~ 2003-10-13 06:13:52.000000000 +0000 > +++ drivers/input/mouse/psmouse-base.c 2003-10-15 00:21:59.000000000 +0000 > @@ -651,10 +651,17 @@ > return 1; > } > > +static int __init psmouse_rate_setup(char *str) > +{ > + get_option(&str, &psmouse_rate); > + return 1; > +} > + > __setup("psmouse_noext", psmouse_noext_setup); > __setup("psmouse_resolution=", psmouse_resolution_setup); > __setup("psmouse_smartscroll=", psmouse_smartscroll_setup); > __setup("psmouse_resetafter=", psmouse_resetafter_setup); > +__setup("psmouse_rate=", psmouse_rate_setup); > > #endif > > -- > Eric Wong -- Vojtech Pavlik SuSE Labs, SuSE CR